From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48258-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10226 invoked by alias); 2 Apr 2007 07:01:14 -0000
Received: (qmail 10206 invoked by uid 22791); 2 Apr 2007 07:01:13 -0000
X-Spam-Check-By: sourceware.org
Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 02 Apr 2007 08:01:10 +0100
Received: from localhost (localhost [127.0.0.1]) 	by filtered-nile.gnat.com (Postfix) with ESMTP id 0E5B948D001; 	Mon,  2 Apr 2007 03:01:07 -0400 (EDT)
Received: from nile.gnat.com ([127.0.0.1])  by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP  id 06129-02-10; Mon,  2 Apr 2007 03:01:06 -0400 (EDT)
Received: from joel.gnat.com (unknown [70.71.0.212]) 	by nile.gnat.com (Postfix) with ESMTP id 730A448CFF6; 	Mon,  2 Apr 2007 03:01:06 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id BBA60E7B43; Mon,  2 Apr 2007 00:02:28 -0700 (PDT)
Date: Mon, 02 Apr 2007 07:01:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dj@redhat.com, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: [RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems
Message-ID: <20070402070228.GD3963@adacore.com>
References: <20070328191845.GB3956@adacore.com> <200703281930.l2SJUYLW003949@greed.delorie.com> <20070328193743.GC3956@adacore.com> <20070328202443.GD3956@adacore.com> <ubqi97hiq.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ubqi97hiq.fsf@gnu.org>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-04/txt/msg00006.txt.bz2

> Sorry for chiming in only now, but I have a few minor comments:

Not a problem at all, Eli. I am not able to followup on them right
now, but I promise I will in a few days.

> >   for (;;)
> >     {
> >       int c1 = tolower (*s1);
> >       int c2 = tolower (*s2);
> 
> Are we sure that strncasecmp's behavior wrt to locales is identical to
> that of tolower's?  If not, the above will introduce a bug in
> non-English locales.

For this question, I'm not sure, actually.

-- 
Joel