From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: Improve end check on rs6000 prologue analyzer
Date: Mon, 12 Mar 2007 21:09:00 -0000 [thread overview]
Message-ID: <20070312210856.GA21953@caradoc.them.org> (raw)
In-Reply-To: <200703122102.l2CL284g022996@brahms.sibelius.xs4all.nl>
On Mon, Mar 12, 2007 at 10:02:08PM +0100, Mark Kettenis wrote:
> Ah, I think I've seen this before. On OpenBSD the tty subsystem does
> tab expansion, wheras on Linux this doesn't happen by default. So we
> must match spaces as well as tabs here. I think that means the second
> pattern is really redundant. How about the attached patch?
Yeesh! I didn't know that. Is there somewhere we could write it down
for test writers who make this same mistake, maybe? I would have
merrily written tests that expected the tab :-(
Your patch looks right to me. I know that I hit the "step over
initial brace" on all platforms on a regular basis - it's not like
this is a new problem. But letting it pass is probably relatively
newer than the IRIX-specific xfail.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-03-12 21:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 21:37 Daniel Jacobowitz
2006-09-30 19:32 ` Mark Kettenis
2006-09-30 20:25 ` Daniel Jacobowitz
2006-10-17 21:21 ` Daniel Jacobowitz
2006-10-17 22:15 ` Mark Kettenis
2006-10-18 5:41 ` Wu Zhou
2006-10-18 14:18 ` Daniel Jacobowitz
2006-10-18 19:58 ` Mark Kettenis
2006-10-18 20:06 ` Daniel Jacobowitz
2006-11-30 20:12 ` Daniel Jacobowitz
2007-02-15 20:20 ` Aman Wardak
2007-03-09 15:05 ` Daniel Jacobowitz
2007-03-11 19:13 ` Mark Kettenis
2007-03-12 12:19 ` Daniel Jacobowitz
2007-03-12 21:02 ` Mark Kettenis
2007-03-12 21:09 ` Daniel Jacobowitz [this message]
2007-03-12 23:05 ` Mark Kettenis
2007-03-13 4:24 ` Eli Zaretskii
2007-04-10 21:10 ` Daniel Jacobowitz
2007-04-11 3:35 ` Eli Zaretskii
2007-04-11 11:11 ` Daniel Jacobowitz
2007-03-13 17:37 ` Daniel Jacobowitz
2007-04-17 2:02 ` Andreas Schwab
2007-04-17 15:02 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312210856.GA21953@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox