From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15959 invoked by alias); 12 Mar 2007 21:09:06 -0000 Received: (qmail 15950 invoked by uid 22791); 12 Mar 2007 21:09:05 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 12 Mar 2007 21:08:58 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HQrlI-0001Kn-LH; Mon, 12 Mar 2007 17:08:56 -0400 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HQrlI-0005iX-FG; Mon, 12 Mar 2007 17:08:56 -0400 Date: Mon, 12 Mar 2007 21:09:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: Improve end check on rs6000 prologue analyzer Message-ID: <20070312210856.GA21953@caradoc.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20060929213726.GA1770@nevyn.them.org> <200609301932.k8UJW0kw030997@elgar.sibelius.xs4all.nl> <20061017212114.GC12643@nevyn.them.org> <200610181958.k9IJw88G009044@elgar.sibelius.xs4all.nl> <20070309150504.GA5166@caradoc.them.org> <200703111913.l2BJDEhC006601@brahms.sibelius.xs4all.nl> <20070312121843.GA24487@caradoc.them.org> <200703122102.l2CL284g022996@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200703122102.l2CL284g022996@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00128.txt.bz2 On Mon, Mar 12, 2007 at 10:02:08PM +0100, Mark Kettenis wrote: > Ah, I think I've seen this before. On OpenBSD the tty subsystem does > tab expansion, wheras on Linux this doesn't happen by default. So we > must match spaces as well as tabs here. I think that means the second > pattern is really redundant. How about the attached patch? Yeesh! I didn't know that. Is there somewhere we could write it down for test writers who make this same mistake, maybe? I would have merrily written tests that expected the tab :-( Your patch looks right to me. I know that I hit the "step over initial brace" on all platforms on a regular basis - it's not like this is a new problem. But letting it pass is probably relatively newer than the IRIX-specific xfail. -- Daniel Jacobowitz CodeSourcery