From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: MI: type prefixes for values [PATCH]
Date: Sun, 04 Feb 2007 14:16:00 -0000 [thread overview]
Message-ID: <20070204141613.GB8764@nevyn.them.org> (raw)
In-Reply-To: <17860.7702.941611.6892@kahikatea.snap.net.nz>
On Sat, Feb 03, 2007 at 06:31:02PM +1300, Nick Roberts wrote:
> Here's a patch which got a bit lost in the mists of time. No regressions.
> 2007-02-03 Nick Roberts <nickrob@snap.net.nz>
>
> * mi/mi-cmd-stack.c (list_args_or_locals): Use common_val_print
> instead of print_variable_value to print values.
Sorry about losing this. The patch is OK; if you have a chance to add
a test for printing references, that would be nice too.
> ! struct value *val;
> ! if (values != PRINT_NO_VALUES)
Looks like you added a space before the tab on that line? Please fix
before commit. Thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-04 14:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dt43qh$sns$1@sea.gmane.org>
2006-03-13 2:44 ` MI: type prefixes for values Nick Roberts
2006-03-17 19:32 ` Vladimir Prus
2006-03-17 19:41 ` Daniel Jacobowitz
2006-03-21 14:58 ` Vladimir Prus
2006-03-24 4:30 ` Daniel Jacobowitz
2006-03-24 9:46 ` Vladimir Prus
2006-03-24 21:02 ` Daniel Jacobowitz
2006-04-06 8:42 ` Vladimir Prus
2006-04-28 6:32 ` Vladimir Prus
2006-05-05 19:25 ` Daniel Jacobowitz
2006-05-06 9:59 ` Nick Roberts
2006-05-15 16:57 ` Daniel Jacobowitz
2006-05-16 6:10 ` Nick Roberts
2007-02-03 5:31 ` MI: type prefixes for values [PATCH] Nick Roberts
2007-02-04 14:16 ` Daniel Jacobowitz [this message]
2007-02-04 21:46 ` Nick Roberts
2006-03-17 22:25 ` MI: type prefixes for values Daniel Jacobowitz
2006-03-18 18:39 ` Nick Roberts
2006-03-20 6:50 ` Daniel Jacobowitz
2006-03-21 10:22 ` Nick Roberts
2006-03-24 4:25 ` Daniel Jacobowitz
2006-03-24 5:26 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070204141613.GB8764@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox