From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1434 invoked by alias); 4 Feb 2007 14:16:42 -0000 Received: (qmail 1422 invoked by uid 22791); 4 Feb 2007 14:16:41 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 04 Feb 2007 14:16:36 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HDiA9-0002NW-Ov; Sun, 04 Feb 2007 09:16:13 -0500 Date: Sun, 04 Feb 2007 14:16:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: MI: type prefixes for values [PATCH] Message-ID: <20070204141613.GB8764@nevyn.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <20060317191207.GA19068@nevyn.them.org> <20060324030332.GB2853@nevyn.them.org> <20060324202056.GA26748@nevyn.them.org> <20060505192535.GM31029@nevyn.them.org> <20060515165354.GG28924@nevyn.them.org> <17860.7702.941611.6892@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17860.7702.941611.6892@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00037.txt.bz2 On Sat, Feb 03, 2007 at 06:31:02PM +1300, Nick Roberts wrote: > Here's a patch which got a bit lost in the mists of time. No regressions. > 2007-02-03 Nick Roberts > > * mi/mi-cmd-stack.c (list_args_or_locals): Use common_val_print > instead of print_variable_value to print values. Sorry about losing this. The patch is OK; if you have a chance to add a test for printing references, that would be nice too. > ! struct value *val; > ! if (values != PRINT_NO_VALUES) Looks like you added a space before the tab on that line? Please fix before commit. Thanks. -- Daniel Jacobowitz CodeSourcery