Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>,
	gdb-patches@sources.redhat.com,
		Nick Roberts <nickrob@snap.net.nz>
Subject: Re: MI: type prefixes for values
Date: Mon, 15 May 2006 16:57:00 -0000	[thread overview]
Message-ID: <20060515165354.GG28924@nevyn.them.org> (raw)
In-Reply-To: <17500.29518.840965.521159@farnswood.snap.net.nz> <20060505192535.GM31029@nevyn.them.org>

> 2006-05-05  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	* valprint.c: Include "exceptions.h".
> 	(val_print): If something goes wrong while printing, supply an
> 	error message.

I have committed this.

On Sat, May 06, 2006 at 09:58:38PM +1200, Nick Roberts wrote:
> It looks like you're catching the error lower down (higher up?)  which allows
> any other values to be printed.  Right?  I like this.

Exactly right - higher up vs lower down is a bit tricky since all of
this stuff is recursive, but probably higher up the call chain.

> > This patch doesn't touch the issue of type prefixes, leaving that to
> > deal with separately.
> 
> If I'm reading this right, I have since realised that my patch to use
> common_val_print was no good because it only prints address and not values for
> things like references

Vladimir noticed that there's a deref_ref argument to common_val_print;
you passed zero, but if you pass one instead, it ought to do the right
thing.

Would you like to try the patch again with that change?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-05-15 16:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <dt43qh$sns$1@sea.gmane.org>
2006-03-13  2:44 ` Nick Roberts
2006-03-17 19:32   ` Vladimir Prus
2006-03-17 19:41     ` Daniel Jacobowitz
2006-03-21 14:58       ` Vladimir Prus
2006-03-24  4:30         ` Daniel Jacobowitz
2006-03-24  9:46           ` Vladimir Prus
2006-03-24 21:02             ` Daniel Jacobowitz
2006-04-06  8:42               ` Vladimir Prus
2006-04-28  6:32                 ` Vladimir Prus
2006-05-05 19:25                   ` Daniel Jacobowitz
2006-05-06  9:59                     ` Nick Roberts
2006-05-15 16:57                       ` Daniel Jacobowitz [this message]
2006-05-16  6:10                         ` Nick Roberts
2007-02-03  5:31                         ` MI: type prefixes for values [PATCH] Nick Roberts
2007-02-04 14:16                           ` Daniel Jacobowitz
2007-02-04 21:46                             ` Nick Roberts
2006-03-17 22:25   ` MI: type prefixes for values Daniel Jacobowitz
2006-03-18 18:39     ` Nick Roberts
2006-03-20  6:50       ` Daniel Jacobowitz
2006-03-21 10:22         ` Nick Roberts
2006-03-24  4:25           ` Daniel Jacobowitz
2006-03-24  5:26             ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060515165354.GG28924@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox