From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1701 invoked by alias); 15 May 2006 16:54:15 -0000 Received: (qmail 1691 invoked by uid 22791); 15 May 2006 16:54:15 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 15 May 2006 16:53:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FfgKQ-000068-MC; Mon, 15 May 2006 12:53:54 -0400 Date: Mon, 15 May 2006 16:57:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts Subject: Re: MI: type prefixes for values Message-ID: <20060515165354.GG28924@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts References: <17427.54333.236860.258115@kahikatea.snap.net.nz> <20060317191207.GA19068@nevyn.them.org> <20060324030332.GB2853@nevyn.them.org> <20060324202056.GA26748@nevyn.them.org> <20060505192535.GM31029@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17500.29518.840965.521159@farnswood.snap.net.nz> <20060505192535.GM31029@nevyn.them.org> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00335.txt.bz2 > 2006-05-05 Daniel Jacobowitz > > * valprint.c: Include "exceptions.h". > (val_print): If something goes wrong while printing, supply an > error message. I have committed this. On Sat, May 06, 2006 at 09:58:38PM +1200, Nick Roberts wrote: > It looks like you're catching the error lower down (higher up?) which allows > any other values to be printed. Right? I like this. Exactly right - higher up vs lower down is a bit tricky since all of this stuff is recursive, but probably higher up the call chain. > > This patch doesn't touch the issue of type prefixes, leaving that to > > deal with separately. > > If I'm reading this right, I have since realised that my patch to use > common_val_print was no good because it only prints address and not values for > things like references Vladimir noticed that there's a deref_ref argument to common_val_print; you passed zero, but if you pass one instead, it ought to do the right thing. Would you like to try the patch again with that change? -- Daniel Jacobowitz CodeSourcery