Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register()
Date: Sat, 20 Jan 2007 04:35:00 -0000	[thread overview]
Message-ID: <20070120043520.GB22013@nevyn.them.org> (raw)
In-Reply-To: <45B0AB10.1060205@de.ibm.com>

On Fri, Jan 19, 2007 at 12:27:12PM +0100, Markus Deuling wrote:
> So no one works with that returning 2. If the check has to be avoided in 
> ppc, then the three lines below can re removed, can't they? Then it's like 

No.  Please think about the comment you're deleting.  This exists so
that gdbserver will not print error messages on kernels which do not
allow us to modify fpscr; there are no ppc64 kernels with this problem,
but ppc32 kernels with the bug were prevalent.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2007-01-20  4:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-18 12:37 Markus Deuling
2007-01-18 16:29 ` Daniel Jacobowitz
2007-01-19 11:27   ` Markus Deuling
2007-01-20  4:35     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070120043520.GB22013@nevyn.them.org \
    --to=drow@false.org \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox