From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26643 invoked by alias); 20 Jan 2007 04:35:34 -0000 Received: (qmail 26631 invoked by uid 22791); 20 Jan 2007 04:35:33 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 20 Jan 2007 04:35:24 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H87wm-0005p0-3b; Fri, 19 Jan 2007 23:35:20 -0500 Date: Sat, 20 Jan 2007 04:35:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Patches Subject: Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register() Message-ID: <20070120043520.GB22013@nevyn.them.org> Mail-Followup-To: Markus Deuling , GDB Patches References: <45AF6A01.1020605@de.ibm.com> <20070118162855.GA14330@nevyn.them.org> <45B0AB10.1060205@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45B0AB10.1060205@de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00412.txt.bz2 On Fri, Jan 19, 2007 at 12:27:12PM +0100, Markus Deuling wrote: > So no one works with that returning 2. If the check has to be avoided in > ppc, then the three lines below can re removed, can't they? Then it's like No. Please think about the comment you're deleting. This exists so that gdbserver will not print error messages on kernels which do not allow us to modify fpscr; there are no ppc64 kernels with this problem, but ppc32 kernels with the bug were prevalent. -- Daniel Jacobowitz CodeSourcery