From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register()
Date: Thu, 18 Jan 2007 16:29:00 -0000 [thread overview]
Message-ID: <20070118162855.GA14330@nevyn.them.org> (raw)
In-Reply-To: <45AF6A01.1020605@de.ibm.com>
On Thu, Jan 18, 2007 at 01:37:21PM +0100, Markus Deuling wrote:
> Hi,
>
> ppc_cannot_store_register() from linux-ppc-low.c returns 2 instead of 1.
> This seems to be broken. In linux-low.c:usr_store_inferior_registers()
> there is following comparison:
>
> if ((*the_low_target.cannot_store_register) (regno) == 1)
> return;
>
> This won't work with ppc low target. The patch returns 1 instead of 2.
That's the whole point - the return value of two exists to avoid that
check.
Why did you want this patch, i.e. does it fix a problem you
encountered?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-18 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 12:37 Markus Deuling
2007-01-18 16:29 ` Daniel Jacobowitz [this message]
2007-01-19 11:27 ` Markus Deuling
2007-01-20 4:35 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070118162855.GA14330@nevyn.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox