From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7319 invoked by alias); 18 Jan 2007 16:29:09 -0000 Received: (qmail 7306 invoked by uid 22791); 18 Jan 2007 16:29:07 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 18 Jan 2007 16:29:01 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H7a8G-0003k6-R2; Thu, 18 Jan 2007 11:28:56 -0500 Date: Thu, 18 Jan 2007 16:29:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Patches Subject: Re: [RFA] gdb/gdbserver/linux-ppc-low.c: Wrong return value in ppc_cannot_store_register() Message-ID: <20070118162855.GA14330@nevyn.them.org> Mail-Followup-To: Markus Deuling , GDB Patches References: <45AF6A01.1020605@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45AF6A01.1020605@de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00402.txt.bz2 On Thu, Jan 18, 2007 at 01:37:21PM +0100, Markus Deuling wrote: > Hi, > > ppc_cannot_store_register() from linux-ppc-low.c returns 2 instead of 1. > This seems to be broken. In linux-low.c:usr_store_inferior_registers() > there is following comparison: > > if ((*the_low_target.cannot_store_register) (regno) == 1) > return; > > This won't work with ppc low target. The patch returns 1 instead of 2. That's the whole point - the return value of two exists to avoid that check. Why did you want this patch, i.e. does it fix a problem you encountered? -- Daniel Jacobowitz CodeSourcery