Ignore two more files for copyright.sh

Ignore two more files for copyright.sh

[Daniel Jacobowitz]

Pie on my face.  I knew this would happen... I suppose I'm impressed
there was only one test depending on exact line numbering.  I've
reverted the changes to those two files.  Sorry!

-- 
Daniel Jacobowitz
CodeSourcery

2007-01-09  Daniel Jacobowitz  <dan@codesourcery.com>

	* copyright.sh (prunes): Add step-line.inp and step-line.c.

Index: copyright.sh
===================================================================
RCS file: /cvs/src/src/gdb/copyright.sh,v
retrieving revision 1.1
diff -u -p -r1.1 copyright.sh
--- copyright.sh	9 Jan 2007 17:08:18 -0000	1.1
+++ copyright.sh	9 Jan 2007 21:36:58 -0000
@@ -61,7 +61,8 @@ byhand="
 "
 
 # Files which should not be modified, either because they are
-# generated, non-FSF, or otherwise special (e.g. license text).
+# generated, non-FSF, or otherwise special (e.g. license text,
+# or test cases which must be sensitive to line numbering).
 prunes="
 COPYING
 COPYING.LIB
@@ -76,6 +77,8 @@ gdbtk
 gdb.gdbtk
 osf-share
 aclocal.m4
+step-line.inp
+step-line.c
 "
 
 ####

Re: Ignore two more files for copyright.sh

[Eli Zaretskii]

> Date: Tue, 9 Jan 2007 16:38:11 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> Pie on my face.  I knew this would happen... I suppose I'm impressed
> there was only one test depending on exact line numbering.

Btw, it's possible to have the copyright notice at the end of the
file, if we say at the beginning something like "Copyright notice at
the end of the file".  That way, the "operational" parts of the file
will never change their line numbers, while your script will find the
copyright if it's within the first 2KB of the file (and if that's not
enough, we can enlarge this value by a one-line change to the
gdb-copyright-update function in your script).

Re: Ignore two more files for copyright.sh

[Daniel Jacobowitz]

On Wed, Jan 10, 2007 at 12:27:51AM +0200, Eli Zaretskii wrote:
> > Date: Tue, 9 Jan 2007 16:38:11 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> > Pie on my face.  I knew this would happen... I suppose I'm impressed
> > there was only one test depending on exact line numbering.
> 
> Btw, it's possible to have the copyright notice at the end of the
> file, if we say at the beginning something like "Copyright notice at
> the end of the file".  That way, the "operational" parts of the file
> will never change their line numbers, while your script will find the
> copyright if it's within the first 2KB of the file (and if that's not
> enough, we can enlarge this value by a one-line change to the
> gdb-copyright-update function in your script).

Thanks.  I'll keep that in mind - it may come in useful.  Since we
pretty much never change these files, I think it's safer to leave them
alone for now.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Ignore two more files for copyright.sh

[Jim Blandy]

Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Tue, 9 Jan 2007 16:38:11 -0500
>> From: Daniel Jacobowitz <drow@false.org>
>> 
>> Pie on my face.  I knew this would happen... I suppose I'm impressed
>> there was only one test depending on exact line numbering.
>
> Btw, it's possible to have the copyright notice at the end of the
> file, if we say at the beginning something like "Copyright notice at
> the end of the file".  That way, the "operational" parts of the file
> will never change their line numbers, while your script will find the
> copyright if it's within the first 2KB of the file (and if that's not
> enough, we can enlarge this value by a one-line change to the
> gdb-copyright-update function in your script).

There are other facilities in lib/gdb.exp for writing tests so that
they don't depend on exact line numbers (see gdb_get_line_number).
This is a practice to avoid whenever possible, anyway.

Re: Ignore two more files for copyright.sh

[Daniel Jacobowitz]

On Tue, Jan 09, 2007 at 03:31:41PM -0800, Jim Blandy wrote:
> There are other facilities in lib/gdb.exp for writing tests so that
> they don't depend on exact line numbers (see gdb_get_line_number).
> This is a practice to avoid whenever possible, anyway.

But these are tests for the compiler's "#line" directive.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Ignore two more files for copyright.sh

[Jim Blandy]

Daniel Jacobowitz <drow@false.org> writes:
> On Tue, Jan 09, 2007 at 03:31:41PM -0800, Jim Blandy wrote:
>> There are other facilities in lib/gdb.exp for writing tests so that
>> they don't depend on exact line numbers (see gdb_get_line_number).
>> This is a practice to avoid whenever possible, anyway.
>
> But these are tests for the compiler's "#line" directive.

Right --- I just wanted to make clear that putting the copyright at
the bottom of the file shouldn't be necessary for almost all files in
the test suite.

Re: Ignore two more files for copyright.sh

[Eli Zaretskii]

> Cc: gdb-patches@sourceware.org
> From: Jim Blandy <jimb@codesourcery.com>
> Date: Tue, 09 Jan 2007 15:58:48 -0800
> >
> > But these are tests for the compiler's "#line" directive.
> 
> Right --- I just wanted to make clear that putting the copyright at
> the bottom of the file shouldn't be necessary for almost all files in
> the test suite.

And _I_ wanted to be sure we knew that when that's necessary, we can
have the cake and eat it, too.