From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23032 invoked by alias); 9 Jan 2007 23:31:11 -0000 Received: (qmail 23023 invoked by uid 22791); 9 Jan 2007 23:31:09 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Jan 2007 23:31:03 +0000 Received: (qmail 28620 invoked from network); 9 Jan 2007 23:31:02 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Jan 2007 23:31:02 -0000 To: Eli Zaretskii Cc: Daniel Jacobowitz , gdb-patches@sourceware.org Subject: Re: Ignore two more files for copyright.sh References: <20070109213811.GE30631@nevyn.them.org> From: Jim Blandy Date: Tue, 09 Jan 2007 23:31:00 -0000 In-Reply-To: (Eli Zaretskii's message of "Wed, 10 Jan 2007 00:27:51 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00283.txt.bz2 Eli Zaretskii writes: >> Date: Tue, 9 Jan 2007 16:38:11 -0500 >> From: Daniel Jacobowitz >> >> Pie on my face. I knew this would happen... I suppose I'm impressed >> there was only one test depending on exact line numbering. > > Btw, it's possible to have the copyright notice at the end of the > file, if we say at the beginning something like "Copyright notice at > the end of the file". That way, the "operational" parts of the file > will never change their line numbers, while your script will find the > copyright if it's within the first 2KB of the file (and if that's not > enough, we can enlarge this value by a one-line change to the > gdb-copyright-update function in your script). There are other facilities in lib/gdb.exp for writing tests so that they don't depend on exact line numbers (see gdb_get_line_number). This is a practice to avoid whenever possible, anyway.