Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: RFC: MI - Detecting change of string contents with variable objects
Date: Mon, 08 Jan 2007 21:41:00 -0000	[thread overview]
Message-ID: <20070108214051.GA26925@nevyn.them.org> (raw)
In-Reply-To: <17826.47099.178726.701606@kahikatea.snap.net.nz>

On Tue, Jan 09, 2007 at 10:30:35AM +1300, Nick Roberts wrote:
> I did this initially, but on re-reading CONTRIBUTE and MAINTAINERS I couldn't
> see why (perhaps Andrew instructed me).  I stopped because I thought the posts
> were very similar to the previous one and I felt I was creating too much noise
> on gdb-patches.  Also the mailing list gdb-cvs, which global maintainers are
> presumably subscribed to, provides this very information.

You're right.  CONTRIBUTE needs updates.  I will put this on my TODO
list for this week.

The current policy, to the best of my knowledge, is supposed to be
"nothing should be checked in that isn't posted to gdb-patches". I
don't repost patches if they are unchanged from the last posted
version, but I do if I've adjusted them.

I'm open to changing it if folks want, but gdb-cvs is much less
convenient - diffs are not included and it isn't a discussion list
so you can't reply.

Anyone have other folklore items they want added to CONTRIBUTE?
Now's the time!  I may adjust the text on testing also.

>  > > I've committed this change, which you might not like, because I think
>  > > Vladimir is agreeable to it.  Of course, I'll make changes, including
>  > > reversion, if there are problems.
>  > 
>  > I think I was pretty clear that approval was conditional on hearing
>  > from Vlad.  You went ahead and committed it anyway.
> 
> You said "This looks fine to me if it's fine with Vlad."  He was part of the
> thread and I addressed his last reservation.  It's not clear to me, at least,
> that he needs to explicitly express his approval.

Sorry if I was unclear.  I would not have said it if Vlad's prior
discussion in the thread had been sufficient - I meant to wait for
him.

> Yes, this is my mistake - sorry.  I'll have to improve the way I handle
> multiple patches.

Thanks.  I realize this is hard, but for this exact reason it is very
important.  And it's usually not a good use of reviewer time to review
patches that cause failures; it is sometimes, so don't take this as an
ironclad rule, but the exceptions should generally be noted in
postings.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-01-08 21:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-18  2:42 Nick Roberts
2006-12-18  7:01 ` Vladimir Prus
2006-12-18  8:15   ` Nick Roberts
2006-12-18  8:36     ` Vladimir Prus
2006-12-18 13:38       ` Daniel Jacobowitz
2006-12-18 21:57         ` Nick Roberts
2006-12-21 15:25           ` Vladimir Prus
2006-12-21 22:28             ` Nick Roberts
2006-12-22  6:16               ` Vladimir Prus
2006-12-22  7:16                 ` Nick Roberts
2006-12-22  7:23                   ` Vladimir Prus
2007-01-03 22:46           ` Daniel Jacobowitz
2007-01-04  4:13             ` Nick Roberts
2007-01-04  4:20               ` Daniel Jacobowitz
2007-01-04  6:10                 ` Nick Roberts
2007-01-04 19:40                   ` Daniel Jacobowitz
2007-01-04 20:35                     ` Nick Roberts
2007-01-04 20:50                       ` Daniel Jacobowitz
2007-01-04 21:00                         ` Vladimir Prus
2007-01-05  4:46                           ` Nick Roberts
2007-01-05 14:49                             ` Daniel Jacobowitz
2007-01-05 21:54                               ` Nick Roberts
2007-01-06  7:07                                 ` Vladimir Prus
2007-01-08 15:51                                 ` Daniel Jacobowitz
2007-01-08 21:30                                   ` Nick Roberts
2007-01-08 21:41                                     ` Daniel Jacobowitz [this message]
2007-01-04 20:57                       ` Vladimir Prus
2007-01-05  2:26                         ` Nick Roberts
2007-01-04 21:05                   ` Vladimir Prus
2007-01-05  1:09                     ` Nick Roberts
2007-01-05 14:44                       ` Daniel Jacobowitz
2007-01-05 14:49                         ` Vladimir Prus
2007-01-05 16:04                       ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070108214051.GA26925@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox