Re: RFC: MI - Detecting change of string contents with variable objects

[Daniel Jacobowitz <drow@false.org>]

On Sat, Jan 06, 2007 at 10:53:40AM +1300, Nick Roberts wrote:
> I've also used:
>  
>   strcmp (var->print_value, print_value) != 0
> 
> since that method seems to be the norm in varobj.c, and GDB generally.

Please, when you commit a patch, post it.  That means the final
version, including a ChangeLog entry.  This holds for obvious patches,
patches that you commit with minor changes, whatever.

> I've committed this change, which you might not like, because I think
> Vladimir is agreeable to it.  Of course, I'll make changes, including
> reversion, if there are problems.

I think I was pretty clear that approval was conditional on hearing
from Vlad.  You went ahead and committed it anyway.

You committed a patch without running the testsuite beforehand.  In
general you shouldn't even post patches without doing that.  We
all make this mistake periodically, but please try harder.

You committed a patch to move the select_frame call without, as far as
I can see from my weekend mail, even posting it.

Nick, I'm disappointed in your behavior.  I'm past caring whether
you are frustrated with the pace of progress; especially after I spent
most of an entire work day that I couldn't really afford to catch up
on patch review.  We have rules that contributors are expected to
follow.  In the future, please follow them.

Let's not back out this patch; we don't need more churn, we'll just fix
it.

-- 
Daniel Jacobowitz
CodeSourcery