From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26478 invoked by alias); 8 Jan 2007 15:51:48 -0000 Received: (qmail 26464 invoked by uid 22791); 8 Jan 2007 15:51:48 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 08 Jan 2007 15:51:42 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H3wmZ-00043e-SP; Mon, 08 Jan 2007 10:51:32 -0500 Date: Mon, 08 Jan 2007 15:51:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: RFC: MI - Detecting change of string contents with variable objects Message-ID: <20070108155131.GA15412@nevyn.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <17798.19683.251190.740216@kahikatea.snap.net.nz> <17821.25837.573239.858406@kahikatea.snap.net.nz> <20070104205039.GH24634@nevyn.them.org> <200701042358.59475.ghost@cs.msu.su> <17821.55336.12928.800849@kahikatea.snap.net.nz> <20070105144926.GC24554@nevyn.them.org> <17822.51428.312664.972742@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17822.51428.312664.972742@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00228.txt.bz2 On Sat, Jan 06, 2007 at 10:53:40AM +1300, Nick Roberts wrote: > I've also used: > > strcmp (var->print_value, print_value) != 0 > > since that method seems to be the norm in varobj.c, and GDB generally. Please, when you commit a patch, post it. That means the final version, including a ChangeLog entry. This holds for obvious patches, patches that you commit with minor changes, whatever. > I've committed this change, which you might not like, because I think > Vladimir is agreeable to it. Of course, I'll make changes, including > reversion, if there are problems. I think I was pretty clear that approval was conditional on hearing from Vlad. You went ahead and committed it anyway. You committed a patch without running the testsuite beforehand. In general you shouldn't even post patches without doing that. We all make this mistake periodically, but please try harder. You committed a patch to move the select_frame call without, as far as I can see from my weekend mail, even posting it. Nick, I'm disappointed in your behavior. I'm past caring whether you are frustrated with the pace of progress; especially after I spent most of an entire work day that I couldn't really afford to catch up on patch review. We have rules that contributors are expected to follow. In the future, please follow them. Let's not back out this patch; we don't need more churn, we'll just fix it. -- Daniel Jacobowitz CodeSourcery