From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10795 invoked by alias); 8 Jan 2007 21:41:10 -0000 Received: (qmail 10783 invoked by uid 22791); 8 Jan 2007 21:41:08 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 08 Jan 2007 21:40:59 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H42Ed-00072I-FQ; Mon, 08 Jan 2007 16:40:51 -0500 Date: Mon, 08 Jan 2007 21:41:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: RFC: MI - Detecting change of string contents with variable objects Message-ID: <20070108214051.GA26925@nevyn.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <17798.19683.251190.740216@kahikatea.snap.net.nz> <17821.25837.573239.858406@kahikatea.snap.net.nz> <20070104205039.GH24634@nevyn.them.org> <200701042358.59475.ghost@cs.msu.su> <17821.55336.12928.800849@kahikatea.snap.net.nz> <20070105144926.GC24554@nevyn.them.org> <17822.51428.312664.972742@kahikatea.snap.net.nz> <20070108155131.GA15412@nevyn.them.org> <17826.47099.178726.701606@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17826.47099.178726.701606@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00245.txt.bz2 On Tue, Jan 09, 2007 at 10:30:35AM +1300, Nick Roberts wrote: > I did this initially, but on re-reading CONTRIBUTE and MAINTAINERS I couldn't > see why (perhaps Andrew instructed me). I stopped because I thought the posts > were very similar to the previous one and I felt I was creating too much noise > on gdb-patches. Also the mailing list gdb-cvs, which global maintainers are > presumably subscribed to, provides this very information. You're right. CONTRIBUTE needs updates. I will put this on my TODO list for this week. The current policy, to the best of my knowledge, is supposed to be "nothing should be checked in that isn't posted to gdb-patches". I don't repost patches if they are unchanged from the last posted version, but I do if I've adjusted them. I'm open to changing it if folks want, but gdb-cvs is much less convenient - diffs are not included and it isn't a discussion list so you can't reply. Anyone have other folklore items they want added to CONTRIBUTE? Now's the time! I may adjust the text on testing also. > > > I've committed this change, which you might not like, because I think > > > Vladimir is agreeable to it. Of course, I'll make changes, including > > > reversion, if there are problems. > > > > I think I was pretty clear that approval was conditional on hearing > > from Vlad. You went ahead and committed it anyway. > > You said "This looks fine to me if it's fine with Vlad." He was part of the > thread and I addressed his last reservation. It's not clear to me, at least, > that he needs to explicitly express his approval. Sorry if I was unclear. I would not have said it if Vlad's prior discussion in the thread had been sufficient - I meant to wait for him. > Yes, this is my mistake - sorry. I'll have to improve the way I handle > multiple patches. Thanks. I realize this is hard, but for this exact reason it is very important. And it's usually not a good use of reviewer time to review patches that cause failures; it is sometimes, so don't take this as an ironclad rule, but the exceptions should generally be noted in postings. -- Daniel Jacobowitz CodeSourcery