From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: Add value field to output of -var-create
Date: Fri, 05 Jan 2007 15:07:00 -0000 [thread overview]
Message-ID: <20070105150747.GD24554@nevyn.them.org> (raw)
In-Reply-To: <17818.12006.696879.216415@kahikatea.snap.net.nz>
On Tue, Jan 02, 2007 at 11:07:34PM +1300, Nick Roberts wrote:
>
> This patch just adds the value field to the output of var-create so that
> the frontend doesn't need to issue another command to find out what it
> is.
>
> If approved, I'll change the tests and documentation accordingly.
Seems fine to me, after we work out what to do with the testsuite. I
went to check whether this should be PRINT_ALL_VALUES or
PRINT_SIMPLE_VALUES but it seems fine the way you've got it - I wish
I could remember the rational for PRINT_SIMPLE_VALUES properly.
One alternative that does not affect the testsuite would be to add
an --all-values option to -var-create.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-01-05 15:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 10:07 Nick Roberts
2007-01-04 20:20 ` Vladimir Prus
2007-01-04 23:22 ` Nick Roberts
2007-01-04 23:24 ` Daniel Jacobowitz
2007-01-05 7:40 ` Vladimir Prus
2007-01-05 15:07 ` Daniel Jacobowitz [this message]
2007-01-05 21:30 ` Nick Roberts
2007-01-07 23:32 ` Daniel Jacobowitz
2007-01-18 9:09 ` Nick Roberts
2007-01-20 19:09 ` Daniel Jacobowitz
2007-01-20 21:53 ` Nick Roberts
2007-02-03 4:54 ` Nick Roberts
2007-02-04 14:10 ` Daniel Jacobowitz
2007-02-04 21:42 ` Nick Roberts
2007-02-08 17:58 ` Daniel Jacobowitz
2007-02-08 20:07 ` Nick Roberts
2007-02-08 20:25 ` Daniel Jacobowitz
2007-02-08 20:27 ` Daniel Jacobowitz
2007-02-08 20:37 ` Nick Roberts
2007-02-08 20:37 ` Daniel Jacobowitz
2007-02-08 20:44 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070105150747.GD24554@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox