From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12503 invoked by alias); 5 Jan 2007 15:07:55 -0000 Received: (qmail 12495 invoked by uid 22791); 5 Jan 2007 15:07:54 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 05 Jan 2007 15:07:49 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H2qfb-0006hJ-Ib; Fri, 05 Jan 2007 10:07:47 -0500 Date: Fri, 05 Jan 2007 15:07:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create Message-ID: <20070105150747.GD24554@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17818.12006.696879.216415@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17818.12006.696879.216415@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00192.txt.bz2 On Tue, Jan 02, 2007 at 11:07:34PM +1300, Nick Roberts wrote: > > This patch just adds the value field to the output of var-create so that > the frontend doesn't need to issue another command to find out what it > is. > > If approved, I'll change the tests and documentation accordingly. Seems fine to me, after we work out what to do with the testsuite. I went to check whether this should be PRINT_ALL_VALUES or PRINT_SIMPLE_VALUES but it seems fine the way you've got it - I wish I could remember the rational for PRINT_SIMPLE_VALUES properly. One alternative that does not affect the testsuite would be to add an --all-values option to -var-create. -- Daniel Jacobowitz CodeSourcery