Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: Add value field to output of -var-create
Date: Thu, 04 Jan 2007 23:24:00 -0000	[thread overview]
Message-ID: <20070104232445.GA2099@nevyn.them.org> (raw)
In-Reply-To: <17821.35879.508258.356360@kahikatea.snap.net.nz>

On Fri, Jan 05, 2007 at 12:22:15PM +1300, Nick Roberts wrote:
>  > I think this is a good change in general. However, the problem is that
>  > a lot of tests hardcode the output from -var-create, and are broken with
>  > this change. I think that instead of adding more hardcoding, we'd
>  > need to replace all creation of varobjs with calls to mi_create_varobj.
>  > Would you be willing to do that?
> 
> It seems unfortunate to me that the output from -var-create gets tested so many
> times but Daniel has just said that mi_gdb_test should really should used even
> if you don't care about the result.

The reason for that advice was the same problem I found with your test;
mi_gdb_test knows how to handle unexpected output and is always careful
to consume a prompt.  If you have a helper function that does something
sufficiently carefully without making it a test, that's fine too!

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-01-04 23:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-02 10:07 Nick Roberts
2007-01-04 20:20 ` Vladimir Prus
2007-01-04 23:22   ` Nick Roberts
2007-01-04 23:24     ` Daniel Jacobowitz [this message]
2007-01-05  7:40     ` Vladimir Prus
2007-01-05 15:07 ` Daniel Jacobowitz
2007-01-05 21:30   ` Nick Roberts
2007-01-07 23:32     ` Daniel Jacobowitz
2007-01-18  9:09   ` Nick Roberts
2007-01-20 19:09     ` Daniel Jacobowitz
2007-01-20 21:53       ` Nick Roberts
2007-02-03  4:54         ` Nick Roberts
2007-02-04 14:10           ` Daniel Jacobowitz
2007-02-04 21:42             ` Nick Roberts
2007-02-08 17:58               ` Daniel Jacobowitz
2007-02-08 20:07                 ` Nick Roberts
2007-02-08 20:25                   ` Daniel Jacobowitz
2007-02-08 20:27                     ` Daniel Jacobowitz
2007-02-08 20:37                       ` Nick Roberts
2007-02-08 20:37                         ` Daniel Jacobowitz
2007-02-08 20:44                     ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070104232445.GA2099@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox