From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8525 invoked by alias); 4 Jan 2007 23:24:56 -0000 Received: (qmail 8516 invoked by uid 22791); 4 Jan 2007 23:24:55 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 04 Jan 2007 23:24:51 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H2bwz-0000YS-8R; Thu, 04 Jan 2007 18:24:45 -0500 Date: Thu, 04 Jan 2007 23:24:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: Add value field to output of -var-create Message-ID: <20070104232445.GA2099@nevyn.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <17821.35879.508258.356360@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17821.35879.508258.356360@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00161.txt.bz2 On Fri, Jan 05, 2007 at 12:22:15PM +1300, Nick Roberts wrote: > > I think this is a good change in general. However, the problem is that > > a lot of tests hardcode the output from -var-create, and are broken with > > this change. I think that instead of adding more hardcoding, we'd > > need to replace all creation of varobjs with calls to mi_create_varobj. > > Would you be willing to do that? > > It seems unfortunate to me that the output from -var-create gets tested so many > times but Daniel has just said that mi_gdb_test should really should used even > if you don't care about the result. The reason for that advice was the same problem I found with your test; mi_gdb_test knows how to handle unexpected output and is always careful to consume a prompt. If you have a helper function that does something sufficiently carefully without making it a test, that's fine too! -- Daniel Jacobowitz CodeSourcery