SPU port for GDB 6.6?

SPU port for GDB 6.6?

[Ulrich Weigand]

Joel,

I was wondering whether there was any chance to get the new SPU port
into the GDB 6.6 release as well.

It's mostly target-specific code, but does require some minor
changes to common code.  We would be talking about the following
set of patches (already committed to mainline):

http://sources.redhat.com/ml/gdb-patches/2006-11/msg00231.html
http://sources.redhat.com/ml/gdb-patches/2006-11/msg00251.html
http://sources.redhat.com/ml/gdb-patches/2006-11/msg00256.html
http://sources.redhat.com/ml/gdb-patches/2006-11/msg00134.html

Would it be OK to apply those to the 6.6 branch at this stage?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: SPU port for GDB 6.6?

[Joel Brobecker]

(sorry for the delay, I tried to review the changes to the common
parts as carefully as possible)

> I was wondering whether there was any chance to get the new SPU port
> into the GDB 6.6 release as well.
> 
> It's mostly target-specific code, but does require some minor
> changes to common code.  We would be talking about the following
> set of patches (already committed to mainline):
> 
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00231.html
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00256.html
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00134.html
> 
> Would it be OK to apply those to the 6.6 branch at this stage?

The above 3 patches are OK for the branch.

> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00251.html

This patch (gdbserver) look ok as far as I'm concerned. It seems
sufficiently obvious in the common bits it is touching, so I don't
think Daniel would object to that. Go ahead and commit, it's simple
enough to back out if he (or someone else!) does.

-- 
Joel

Re: SPU port for GDB 6.6?

[Daniel Jacobowitz]

On Fri, Nov 24, 2006 at 11:25:20AM -0800, Joel Brobecker wrote:
> > http://sources.redhat.com/ml/gdb-patches/2006-11/msg00251.html
> 
> This patch (gdbserver) look ok as far as I'm concerned. It seems
> sufficiently obvious in the common bits it is touching, so I don't
> think Daniel would object to that. Go ahead and commit, it's simple
> enough to back out if he (or someone else!) does.

I don't, as it happens; all is well.

-- 
Daniel Jacobowitz
CodeSourcery

Re: SPU port for GDB 6.6?

[Ulrich Weigand]

Daniel Jacobowitz wrote:
> On Fri, Nov 24, 2006 at 11:25:20AM -0800, Joel Brobecker wrote:
> > > http://sources.redhat.com/ml/gdb-patches/2006-11/msg00251.html
> > 
> > This patch (gdbserver) look ok as far as I'm concerned. It seems
> > sufficiently obvious in the common bits it is touching, so I don't
> > think Daniel would object to that. Go ahead and commit, it's simple
> > enough to back out if he (or someone else!) does.
> 
> I don't, as it happens; all is well.

Thanks Joel and Dan, I've now committed all four patches to the 6.6
branch, as well as the change to MAINTAINERS and NEWS.

I've also changed NEWS in mainline to indicate the SPU port is
already supported in GDB 6.6.

Bye,
Ulrich

ChangeLog:

	* NEWS: SPU target is already supported in GDB 6.6.

Index: gdb/NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.202
diff -u -p -r1.202 NEWS
--- gdb/NEWS	22 Nov 2006 19:41:17 -0000	1.202
+++ gdb/NEWS	24 Nov 2006 20:16:39 -0000
@@ -3,10 +3,6 @@
 
 *** Changes since GDB 6.6
 
-* New targets
-
-Cell Broadband Engine SPU	spu-elf
-
 * The GDB remote stub, gdbserver, now has lower overhead for high 
 frequency signals (e.g. SIGALRM) via the QPassSignals packet.
 
@@ -22,6 +18,7 @@ QPassSignals:
 * New targets
 
 Xtensa				xtensa-elf
+Cell Broadband Engine SPU	spu-elf
 
 * GDB can now be configured as a cross-debugger targeting native Windows
 (mingw32) or Cygwin.  It can communicate with a remote debugging stub


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com