Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic

[Daniel Jacobowitz <drow@false.org>]

On Thu, Oct 19, 2006 at 04:52:29AM +1300, Nick Roberts wrote:
> Daniel Jacobowitz writes:
>  > On Wed, Oct 18, 2006 at 12:44:20PM +1300, Nick Roberts wrote:
>  > > The name deprecated_set_gdb_event_hooks suggests that they're earmarked for
>  > > removal.  These hooks only seem to get get in one place so presumably they
>  > > could be set up once at initialisation and left with that value.
>  > 
>  > They're also used by insight.  This is one of the sucky things about
>  > having insight directly linked to GDB.
> 
> OK, how about just using the hack in mi_cmd_thread_select for
> mi_cmd_break_insert for the moment.

This is just nasty.  I believe I pointed you at Ulrich's analysis of
this problem upthread:

  http://sources.redhat.com/ml/gdb/2006-10/msg00021.html

It seems pretty clear to me that the patch which switched things to
return the result of catch_exceptions_with_msg was wrong.  The
functions are defined to return an enum gdb_rc.  Can't we make
them do that again?  Simple, obviously correct.

-- 
Daniel Jacobowitz
CodeSourcery