From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic
Date: Tue, 17 Oct 2006 21:31:00 -0000 [thread overview]
Message-ID: <20061017213119.GA14010@nevyn.them.org> (raw)
In-Reply-To: <17717.17922.450312.898237@kahikatea.snap.net.nz>
On Wed, Oct 18, 2006 at 10:07:14AM +1300, Nick Roberts wrote:
>
> This patch fixes PR mi/2086. There may be similar bugs arising from using
> catch_exceptions_with_msg inappropriately.
Is this the whole patch? I guess you updated the caller too.
I think removing catch_exceptions_with_msg isn't enough - if you look
at the call site, it's not prepared for an error() to escape there.
It would have to use a cleanup for deprecated_set_gdb_event_hooks.
Ulrich posted a detailed analysis of this to gdb@ on Oct. 4th. I think
it was just a buggy conversion to catch_exceptions_with_msg; we should
check everywhere touched by whatever patch that was. Looks like it was
from 2005-01-13.
> I could slowly work my way through the mi PRs in the bug database. Can I close
> a bug or is that another level? (I don't know my password, if I have one).
I'll send it offlist. Feel free to close bugs.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-10-17 21:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 21:10 Nick Roberts
2006-10-17 21:31 ` Daniel Jacobowitz [this message]
2006-10-17 21:51 ` Nick Roberts
2006-10-17 21:57 ` Daniel Jacobowitz
2006-10-17 22:10 ` Nick Roberts
2006-10-17 23:47 ` Nick Roberts
2006-10-18 15:31 ` Daniel Jacobowitz
2006-10-18 15:55 ` Nick Roberts
2006-11-17 21:16 ` Daniel Jacobowitz
2006-11-19 4:39 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061017213119.GA14010@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox