From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10440 invoked by alias); 17 Oct 2006 21:31:24 -0000 Received: (qmail 10430 invoked by uid 22791); 17 Oct 2006 21:31:23 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Oct 2006 21:31:21 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GZwWt-0003hA-Up; Tue, 17 Oct 2006 17:31:20 -0400 Date: Tue, 17 Oct 2006 21:31:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic Message-ID: <20061017213119.GA14010@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17717.17922.450312.898237@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17717.17922.450312.898237@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00195.txt.bz2 On Wed, Oct 18, 2006 at 10:07:14AM +1300, Nick Roberts wrote: > > This patch fixes PR mi/2086. There may be similar bugs arising from using > catch_exceptions_with_msg inappropriately. Is this the whole patch? I guess you updated the caller too. I think removing catch_exceptions_with_msg isn't enough - if you look at the call site, it's not prepared for an error() to escape there. It would have to use a cleanup for deprecated_set_gdb_event_hooks. Ulrich posted a detailed analysis of this to gdb@ on Oct. 4th. I think it was just a buggy conversion to catch_exceptions_with_msg; we should check everywhere touched by whatever patch that was. Looks like it was from 2005-01-13. > I could slowly work my way through the mi PRs in the bug database. Can I close > a bug or is that another level? (I don't know my password, if I have one). I'll send it offlist. Feel free to close bugs. -- Daniel Jacobowitz CodeSourcery