From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17846 invoked by alias); 17 Nov 2006 21:16:17 -0000 Received: (qmail 17838 invoked by uid 22791); 17 Nov 2006 21:16:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 17 Nov 2006 21:16:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GlB40-0003n8-Eg; Fri, 17 Nov 2006 16:15:56 -0500 Date: Fri, 17 Nov 2006 21:16:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com, Ulrich.Weigand@de.ibm.com Subject: Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic Message-ID: <20061117211556.GA13961@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com, Ulrich.Weigand@de.ibm.com References: <17717.17922.450312.898237@kahikatea.snap.net.nz> <20061017213119.GA14010@nevyn.them.org> <17717.20397.279496.222573@kahikatea.snap.net.nz> <20061017215754.GA15210@nevyn.them.org> <17717.27348.977065.613551@kahikatea.snap.net.nz> <20061018153109.GB10436@nevyn.them.org> <17718.19901.569519.210795@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17718.19901.569519.210795@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00185.txt.bz2 On Thu, Oct 19, 2006 at 04:52:29AM +1300, Nick Roberts wrote: > Daniel Jacobowitz writes: > > On Wed, Oct 18, 2006 at 12:44:20PM +1300, Nick Roberts wrote: > > > The name deprecated_set_gdb_event_hooks suggests that they're earmarked for > > > removal. These hooks only seem to get get in one place so presumably they > > > could be set up once at initialisation and left with that value. > > > > They're also used by insight. This is one of the sucky things about > > having insight directly linked to GDB. > > OK, how about just using the hack in mi_cmd_thread_select for > mi_cmd_break_insert for the moment. This is just nasty. I believe I pointed you at Ulrich's analysis of this problem upthread: http://sources.redhat.com/ml/gdb/2006-10/msg00021.html It seems pretty clear to me that the patch which switched things to return the result of catch_exceptions_with_msg was wrong. The functions are defined to return an enum gdb_rc. Can't we make them do that again? Simple, obviously correct. -- Daniel Jacobowitz CodeSourcery