From: Vladimir Prus <vladimir@codesourcery.com>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: MI: -var-list-children --simple-values
Date: Wed, 15 Nov 2006 11:50:00 -0000 [thread overview]
Message-ID: <200611151450.19852.vladimir@codesourcery.com> (raw)
In-Reply-To: <17754.63307.487745.34360@kahikatea.snap.net.nz>
On Wednesday 15 November 2006 14:17, Nick Roberts wrote:
> > -var-list-children --simple-values
> >
> > is broken on mainline. Printing children of any C++ structure results in
> > segfault. The problem is that C++ structures have "public" fake child
> > that has no type, so mi_print_value_p tries to access properties of a
> > NULL type.
> >
> > This is easy to fix, but given that printing C++ structures is a
> > mainstream use-case, and no IDE developer ever complained, this suggests
> > that this feature is not used. Rather than carry it along, how about
> > just removing it?
>
> ISTR Daniel J wanted --simple-values for consistency with
> -stack-list-locals. As it's easy to fix, I suggest doing that.
There are many things that are easy to fix, but it does not mean we need to
keep unused functionality.
Perhaps Dan can comment why he really needed --simple-values.
> I also note
> a mistake in the error message. Both are fixed below.
I don't see any regression test for this crash. Are you going to provide one?
- Volodya
next prev parent reply other threads:[~2006-11-15 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611151250.11654.vladimir@codesourcery.com>
2006-11-15 11:21 ` Nick Roberts
2006-11-15 11:50 ` Vladimir Prus [this message]
2006-11-15 14:44 ` Daniel Jacobowitz
2006-11-15 14:55 ` Vladimir Prus
2006-11-15 15:09 ` Daniel Jacobowitz
2006-11-15 16:29 ` Vladimir Prus
2006-11-15 20:29 ` Nick Roberts
2006-11-29 9:35 ` Vladimir Prus
2006-11-29 9:58 ` Nick Roberts
2006-11-16 15:57 ` Daniel Jacobowitz
2006-11-15 19:55 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611151450.19852.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox