From: Nick Roberts <nickrob@snap.net.nz>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: MI: -var-list-children --simple-values
Date: Wed, 29 Nov 2006 09:58:00 -0000 [thread overview]
Message-ID: <17773.22732.724678.784708@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200611291234.43123.vladimir@codesourcery.com>
> > > So, while --simple-values might be reasonable for -stack-list-locals,
> > > it's not all that needed for -var-list-children.
> >
> > I can't see where it's needed, but its more trouble to remove than to fix.
>
> Why? Removing is really quick. Fixing requires:
I don't really want to remove it as I didn't want to add it in the first place.
I don't mind it being there: I just don't use it. I guess if you want remove
it then it's clearly less work (for me!) and that's fine with me too but you
need to remove the test and the description in the manual too. More
imporatantly I think Daniel J arranged so that -var-list-children,
-stack-list-locals and -var-update shared code so you'll have to break that up.
> - Fix itself (you've posted it)
> - Documentation (specific to -var-list-children).
> - Testcase
>
> I did not see the latter two, so I suppose it's still some work ;-)
If we fix it no changes are needed there unless you want to add a test for the
fix.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2006-11-29 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611151250.11654.vladimir@codesourcery.com>
2006-11-15 11:21 ` Nick Roberts
2006-11-15 11:50 ` Vladimir Prus
2006-11-15 14:44 ` Daniel Jacobowitz
2006-11-15 14:55 ` Vladimir Prus
2006-11-15 15:09 ` Daniel Jacobowitz
2006-11-15 16:29 ` Vladimir Prus
2006-11-15 20:29 ` Nick Roberts
2006-11-29 9:35 ` Vladimir Prus
2006-11-29 9:58 ` Nick Roberts [this message]
2006-11-16 15:57 ` Daniel Jacobowitz
2006-11-15 19:55 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17773.22732.724678.784708@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox