From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19027 invoked by alias); 29 Nov 2006 09:58:49 -0000 Received: (qmail 19016 invoked by uid 22791); 29 Nov 2006 09:58:48 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Nov 2006 09:58:42 +0000 Received: from kahikatea.snap.net.nz (p202-124-125-243.snap.net.nz [202.124.125.243]) by viper.snap.net.nz (Postfix) with ESMTP id 1AE363DA820; Wed, 29 Nov 2006 22:59:27 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 768B6BE452; Wed, 29 Nov 2006 22:54:22 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17773.22732.724678.784708@kahikatea.snap.net.nz> Date: Wed, 29 Nov 2006 09:58:00 -0000 To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: MI: -var-list-children --simple-values In-Reply-To: <200611291234.43123.vladimir@codesourcery.com> References: <200611151250.11654.vladimir@codesourcery.com> <200611151929.29567.vladimir@codesourcery.com> <17755.30642.667665.206754@kahikatea.snap.net.nz> <200611291234.43123.vladimir@codesourcery.com> X-Mailer: VM 7.19 under Emacs 22.0.91.6 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00376.txt.bz2 > > > So, while --simple-values might be reasonable for -stack-list-locals, > > > it's not all that needed for -var-list-children. > > > > I can't see where it's needed, but its more trouble to remove than to fix. > > Why? Removing is really quick. Fixing requires: I don't really want to remove it as I didn't want to add it in the first place. I don't mind it being there: I just don't use it. I guess if you want remove it then it's clearly less work (for me!) and that's fine with me too but you need to remove the test and the description in the manual too. More imporatantly I think Daniel J arranged so that -var-list-children, -stack-list-locals and -var-update shared code so you'll have to break that up. > - Fix itself (you've posted it) > - Documentation (specific to -var-list-children). > - Testcase > > I did not see the latter two, so I suppose it's still some work ;-) If we fix it no changes are needed there unless you want to add a test for the fix. -- Nick http://www.inet.net.nz/~nickrob