From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2630 invoked by alias); 15 Nov 2006 11:50:42 -0000 Received: (qmail 2621 invoked by uid 22791); 15 Nov 2006 11:50:41 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Nov 2006 11:50:32 +0000 Received: (qmail 12218 invoked from network); 15 Nov 2006 11:50:29 -0000 Received: from unknown (HELO ?172.16.64.38?) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Nov 2006 11:50:29 -0000 From: Vladimir Prus To: Nick Roberts Subject: Re: MI: -var-list-children --simple-values Date: Wed, 15 Nov 2006 11:50:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200611151250.11654.vladimir@codesourcery.com> <17754.63307.487745.34360@kahikatea.snap.net.nz> In-Reply-To: <17754.63307.487745.34360@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611151450.19852.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00121.txt.bz2 On Wednesday 15 November 2006 14:17, Nick Roberts wrote: > > -var-list-children --simple-values > > > > is broken on mainline. Printing children of any C++ structure results in > > segfault. The problem is that C++ structures have "public" fake child > > that has no type, so mi_print_value_p tries to access properties of a > > NULL type. > > > > This is easy to fix, but given that printing C++ structures is a > > mainstream use-case, and no IDE developer ever complained, this suggests > > that this feature is not used. Rather than carry it along, how about > > just removing it? > > ISTR Daniel J wanted --simple-values for consistency with > -stack-list-locals. As it's easy to fix, I suggest doing that. There are many things that are easy to fix, but it does not mean we need to keep unused functionality. Perhaps Dan can comment why he really needed --simple-values. > I also note > a mistake in the error message. Both are fixed below. I don't see any regression test for this crash. Are you going to provide one? - Volodya