From: Daniel Jacobowitz <drow@false.org>
To: PAUL GILLIAM <pgilliam@us.ibm.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [commit] signal trampoline frame cache corruption
Date: Mon, 13 Nov 2006 17:46:00 -0000 [thread overview]
Message-ID: <20061113174556.GA30708@nevyn.them.org> (raw)
In-Reply-To: <1163439327.3428.22.camel@dufur.beaverton.ibm.com>
On Mon, Nov 13, 2006 at 09:35:27AM -0800, PAUL GILLIAM wrote:
> Thanks Mark and Daniel.
>
> I have committed the attached patch
> + if (ppc_floating_point_unit_p (gdbarch)) {
> + /* Floating point registers. */
> + for (i = 0; i < 32; i++)
> + {
> + int regnum = i + FP0_REGNUM;
> + trad_frame_set_reg_addr (this_cache, regnum, fpregs + i * tdep->wordsize);
> + }
> + trad_frame_set_reg_addr (this_cache, tdep->ppc_fpscr_regnum,
> + fpregs + 32 * tdep->wordsize);
> + }
You had your indentation and braces right the last time you posted
this; what's happened to them? The version you've committed looks
like it's been reindented mostly to the Linux kernel style.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-11-13 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 19:41 patch: signal trampoline frame cache corruption (repost?) PAUL GILLIAM
2006-10-31 23:28 ` Mark Kettenis
2006-11-03 17:58 ` PAUL GILLIAM
2006-11-10 21:22 ` Daniel Jacobowitz
2006-11-13 17:42 ` [commit] signal trampoline frame cache corruption PAUL GILLIAM
2006-11-13 17:46 ` Daniel Jacobowitz [this message]
2006-11-13 18:57 ` PAUL GILLIAM
2006-11-13 19:05 ` Daniel Jacobowitz
2006-11-14 1:50 ` PAUL GILLIAM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061113174556.GA30708@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pgilliam@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox