Re: patch: signal trampoline frame cache corruption (repost?)

[PAUL GILLIAM <pgilliam@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Wed, 2006-11-01 at 00:28 +0100, Mark Kettenis wrote:
> > . . .
> > Ok to commit?  (This is almost an obvious fix, isn't it?)
> 
> Not as you've posted it, since it doesn't adhere to the GNU coding
> style.  But the idea seems alright to me.
> 
> Mark

Ufda!

Sorry about the formatting.  I fixed that, and included a ChangeLog
entry which I also forgot the first time.

Now is it OK to commit?

-=# Paul #=-

[-- Attachment #2: fix-sigtramp-cache.patch --]
[-- Type: text/x-patch, Size: 1381 bytes --]


2006-11-03  Paul Gilliam <pgilliam@us.ibm.com>
	
	* ppc-linux-tdep.c (ppc_linux_sigtramp_cache):  Only
	deal with the floating point registers if the processor
	has a floating point unit.

Index: ppc-linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-linux-tdep.c,v
retrieving revision 1.78
diff -a -u -r1.78 ppc-linux-tdep.c
--- ppc-linux-tdep.c	18 Apr 2006 19:20:06 -0000	1.78
+++ ppc-linux-tdep.c	3 Nov 2006 17:45:28 -0000
@@ -916,14 +916,18 @@
   trad_frame_set_reg_addr (this_cache, tdep->ppc_cr_regnum,
 			   gpregs + 38 * tdep->wordsize);
 
-  /* Floating point registers.  */
-  for (i = 0; i < 32; i++)
+  if (ppc_floating_point_unit_p(gdbarch))
     {
-      int regnum = i + FP0_REGNUM;
-      trad_frame_set_reg_addr (this_cache, regnum, fpregs + i * tdep->wordsize);
+      /* Floating point registers.  */
+      for (i = 0; i < 32; i++)
+        {
+          int regnum = i + FP0_REGNUM;
+          trad_frame_set_reg_addr (this_cache, regnum, 
+				   fpregs + i * tdep->wordsize);
+        }
+      trad_frame_set_reg_addr (this_cache, tdep->ppc_fpscr_regnum,
+                               fpregs + 32 * tdep->wordsize);
     }
-  trad_frame_set_reg_addr (this_cache, tdep->ppc_fpscr_regnum,
-			   fpregs + 32 * tdep->wordsize);
   trad_frame_set_id (this_cache, frame_id_build (base, func));
 }