From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10309 invoked by alias); 13 Nov 2006 17:46:07 -0000 Received: (qmail 10301 invoked by uid 22791); 13 Nov 2006 17:46:07 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 13 Nov 2006 17:45:59 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gjfsa-00081J-E3; Mon, 13 Nov 2006 12:45:56 -0500 Date: Mon, 13 Nov 2006 17:46:00 -0000 From: Daniel Jacobowitz To: PAUL GILLIAM Cc: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [commit] signal trampoline frame cache corruption Message-ID: <20061113174556.GA30708@nevyn.them.org> Mail-Followup-To: PAUL GILLIAM , gdb-patches@sourceware.org, Mark Kettenis References: <1162323227.3428.9.camel@dufur.beaverton.ibm.com> <200610312328.k9VNScRC012608@elgar.sibelius.xs4all.nl> <1162576236.3428.17.camel@dufur.beaverton.ibm.com> <20061110212202.GF1115@nevyn.them.org> <1163439327.3428.22.camel@dufur.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1163439327.3428.22.camel@dufur.beaverton.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00100.txt.bz2 On Mon, Nov 13, 2006 at 09:35:27AM -0800, PAUL GILLIAM wrote: > Thanks Mark and Daniel. > > I have committed the attached patch > + if (ppc_floating_point_unit_p (gdbarch)) { > + /* Floating point registers. */ > + for (i = 0; i < 32; i++) > + { > + int regnum = i + FP0_REGNUM; > + trad_frame_set_reg_addr (this_cache, regnum, fpregs + i * tdep->wordsize); > + } > + trad_frame_set_reg_addr (this_cache, tdep->ppc_fpscr_regnum, > + fpregs + 32 * tdep->wordsize); > + } You had your indentation and braces right the last time you posted this; what's happened to them? The version you've committed looks like it's been reindented mostly to the Linux kernel style. -- Daniel Jacobowitz CodeSourcery