[RFA/sparc] Fix step-bt.exp: backtrace after second instruction step

[RFA/sparc] Fix step-bt.exp: backtrace after second instruction step

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hello,

I encountered on sparc the same problem I saw on i386: When scanning
a function prologue, if an instruction is replaced by a breakpoint,
we read the breakpoint instead of reading the original instruction.

Fixed using the same method as in i386...

2006-11-08  Joel Brobecker  <brobecker@adacore.com>

        * sparc-tdep.c (sparc_fetch_instruction): Read instruction
        using read_memory_nobpt.

Tested on sparc-solaris, no regression, and fixes one FAIL in
step-bt.exp.

OK to apply?
-- 
Joel

[-- Attachment #2: sparc-tdep.c.diff --]
[-- Type: text/plain, Size: 544 bytes --]

Index: sparc-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-tdep.c,v
retrieving revision 1.173
diff -u -p -r1.173 sparc-tdep.c
--- sparc-tdep.c	12 Jul 2006 18:13:45 -0000	1.173
+++ sparc-tdep.c	9 Nov 2006 04:54:05 -0000
@@ -99,7 +99,7 @@ sparc_fetch_instruction (CORE_ADDR pc)
   int i;
 
   /* If we can't read the instruction at PC, return zero.  */
-  if (target_read_memory (pc, buf, sizeof (buf)))
+  if (read_memory_nobpt (pc, buf, sizeof (buf)))
     return 0;
 
   insn = 0;

Re: [RFA/sparc] Fix step-bt.exp: backtrace after second instruction step

[Daniel Jacobowitz]

On Wed, Nov 08, 2006 at 08:58:01PM -0800, Joel Brobecker wrote:
> Hello,
> 
> I encountered on sparc the same problem I saw on i386: When scanning
> a function prologue, if an instruction is replaced by a breakpoint,
> we read the breakpoint instead of reading the original instruction.
> 
> Fixed using the same method as in i386...

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA/sparc] Fix step-bt.exp: backtrace after second instruction step

[Joel Brobecker]

> > I encountered on sparc the same problem I saw on i386: When scanning
> > a function prologue, if an instruction is replaced by a breakpoint,
> > we read the breakpoint instead of reading the original instruction.
> > 
> > Fixed using the same method as in i386...
> 
> OK.

Thank you. Checked in.

-- 
Joel