Re: New port to Cell SPU

Re: New port to Cell SPU

[Alan Modra]

On Wed, Oct 25, 2006 at 04:16:45PM +0930, Alan Modra wrote:
> This implements binutils support for the Sony/Toshiba/IBM Synergistic
> Processor Unit.  One feature of this port is a built-in linker overlay
[snip]

This fixes a make -j problem with this port.  The newly built
assembler is used to assemble the overlay manager code, so we need
to ensure that the assembler is in fact built before attempting to
use it.  OK to apply to gcc and src repositories?

	* configure.in (serialization_dependencies): Make all-ld depend
	on all-gas for spu target in maintainer mode.
	* configure: Regenerate.

Index: configure.in
===================================================================
RCS file: /cvs/src/src/configure.in,v
retrieving revision 1.318
diff -u -p -r1.318 configure.in
--- configure.in	27 Sep 2006 16:20:49 -0000	1.318
+++ configure.in	25 Oct 2006 01:14:11 -0000
@@ -1957,6 +1957,11 @@ for item in ${target_configdirs} ; do
   esac
   olditem=${item}
 done
+# spu ld makefile invokes as-new in maintainer mode.
+test "x${enable_maintainer_mode}" = xyes &&
+case ${target} in
+  spu*) echo "all-ld: all-gas" >> serdep.tmp ;;
+esac
 serialization_dependencies=serdep.tmp
 AC_SUBST_FILE(serialization_dependencies)
 

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: New port to Cell SPU

[Paolo Bonzini]

Alan Modra wrote:
> On Wed, Oct 25, 2006 at 04:16:45PM +0930, Alan Modra wrote:
>> This implements binutils support for the Sony/Toshiba/IBM Synergistic
>> Processor Unit.  One feature of this port is a built-in linker overlay
> [snip]
> 
> This fixes a make -j problem with this port.  The newly built
> assembler is used to assemble the overlay manager code, so we need
> to ensure that the assembler is in fact built before attempting to
> use it.  OK to apply to gcc and src repositories?

I'd use a target template such as mt-wince, including

all-ld: $(MAINT) all-gas

Nitpicking yours,

Paolo

Re: New port to Cell SPU

[Alan Modra]

On Wed, Oct 25, 2006 at 04:39:39PM +0900, Paolo Bonzini wrote:
> Alan Modra wrote:
> >On Wed, Oct 25, 2006 at 04:16:45PM +0930, Alan Modra wrote:
> >>This implements binutils support for the Sony/Toshiba/IBM Synergistic
> >>Processor Unit.  One feature of this port is a built-in linker overlay
> >[snip]
> >
> >This fixes a make -j problem with this port.  The newly built
> >assembler is used to assemble the overlay manager code, so we need
> >to ensure that the assembler is in fact built before attempting to
> >use it.  OK to apply to gcc and src repositories?
> 
> I'd use a target template such as mt-wince, including
> 
> all-ld: $(MAINT) all-gas
> 
> Nitpicking yours,

I thought we were moving away from makefile fragments?  Maybe that was
just in the gcc tree.  Here's the alternate implementation.

	* configure.in:  Handle spu makefile frag.
	* configure: Regenerate.
	* Makefile.in (MAINT): Define
	(MAINTAINER_MODE_FALSE, MAINTAINER_MODE_TRUE): Define.
	* config/mt-spu: New file.

Index: configure.in
===================================================================
RCS file: /cvs/src/src/configure.in,v
retrieving revision 1.318
diff -u -p -r1.318 configure.in
--- configure.in	27 Sep 2006 16:20:49 -0000	1.318
+++ configure.in	25 Oct 2006 23:49:42 -0000
@@ -1623,6 +1623,9 @@ extra_nmflags_for_target=
 extra_ranlibflags_for_target=
 target_makefile_frag=/dev/null
 case "${target}" in
+  spu-*-*)
+    target_makefile_frag="config/mt-spu"
+    ;;
   *-*-netware*)
     target_makefile_frag="config/mt-netware"
     ;;
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/Makefile.in,v
retrieving revision 1.248
diff -u -p -r1.248 Makefile.in
--- Makefile.in	17 Oct 2006 04:23:48 -0000	1.248
+++ Makefile.in	25 Oct 2006 23:49:49 -0000
@@ -70,6 +70,9 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
 INSTALL_DATA = @INSTALL_DATA@
 LN = @LN@
 LN_S = @LN_S@
+MAINT = @MAINT@
+MAINTAINER_MODE_FALSE = @MAINTAINER_MODE_FALSE@
+MAINTAINER_MODE_TRUE = @MAINTAINER_MODE_TRUE@
 
 # -------------------------------------------------
 # Miscellaneous non-standard autoconf-set variables
Index: config/mt-spu
===================================================================
RCS file: config/mt-spu
diff -N config/mt-spu
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ config/mt-spu	25 Oct 2006 23:49:49 -0000
@@ -0,0 +1,2 @@
+# spu ld makefile invokes as-new in maintainer mode.
+all-ld: $(MAINT) all-gas

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre