From: Alan Modra <amodra@bigpond.net.au>
To: Paolo Bonzini <paolo.bonzini@lu.unisi.ch>
Cc: binutils@sourceware.org, gcc-patches@gcc.gnu.org,
gdb-patches@sourceware.org
Subject: Re: New port to Cell SPU
Date: Wed, 25 Oct 2006 23:55:00 -0000 [thread overview]
Message-ID: <20061025235613.GM26170@bubble.grove.modra.org> (raw)
In-Reply-To: <453F14BB.4070102@lu.unisi.ch>
On Wed, Oct 25, 2006 at 04:39:39PM +0900, Paolo Bonzini wrote:
> Alan Modra wrote:
> >On Wed, Oct 25, 2006 at 04:16:45PM +0930, Alan Modra wrote:
> >>This implements binutils support for the Sony/Toshiba/IBM Synergistic
> >>Processor Unit. One feature of this port is a built-in linker overlay
> >[snip]
> >
> >This fixes a make -j problem with this port. The newly built
> >assembler is used to assemble the overlay manager code, so we need
> >to ensure that the assembler is in fact built before attempting to
> >use it. OK to apply to gcc and src repositories?
>
> I'd use a target template such as mt-wince, including
>
> all-ld: $(MAINT) all-gas
>
> Nitpicking yours,
I thought we were moving away from makefile fragments? Maybe that was
just in the gcc tree. Here's the alternate implementation.
* configure.in: Handle spu makefile frag.
* configure: Regenerate.
* Makefile.in (MAINT): Define
(MAINTAINER_MODE_FALSE, MAINTAINER_MODE_TRUE): Define.
* config/mt-spu: New file.
Index: configure.in
===================================================================
RCS file: /cvs/src/src/configure.in,v
retrieving revision 1.318
diff -u -p -r1.318 configure.in
--- configure.in 27 Sep 2006 16:20:49 -0000 1.318
+++ configure.in 25 Oct 2006 23:49:42 -0000
@@ -1623,6 +1623,9 @@ extra_nmflags_for_target=
extra_ranlibflags_for_target=
target_makefile_frag=/dev/null
case "${target}" in
+ spu-*-*)
+ target_makefile_frag="config/mt-spu"
+ ;;
*-*-netware*)
target_makefile_frag="config/mt-netware"
;;
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/Makefile.in,v
retrieving revision 1.248
diff -u -p -r1.248 Makefile.in
--- Makefile.in 17 Oct 2006 04:23:48 -0000 1.248
+++ Makefile.in 25 Oct 2006 23:49:49 -0000
@@ -70,6 +70,9 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
INSTALL_DATA = @INSTALL_DATA@
LN = @LN@
LN_S = @LN_S@
+MAINT = @MAINT@
+MAINTAINER_MODE_FALSE = @MAINTAINER_MODE_FALSE@
+MAINTAINER_MODE_TRUE = @MAINTAINER_MODE_TRUE@
# -------------------------------------------------
# Miscellaneous non-standard autoconf-set variables
Index: config/mt-spu
===================================================================
RCS file: config/mt-spu
diff -N config/mt-spu
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ config/mt-spu 25 Oct 2006 23:49:49 -0000
@@ -0,0 +1,2 @@
+# spu ld makefile invokes as-new in maintainer mode.
+all-ld: $(MAINT) all-gas
--
Alan Modra
IBM OzLabs - Linux Technology Centre
prev parent reply other threads:[~2006-10-25 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061025064645.GI26170@bubble.grove.modra.org>
2006-10-25 7:18 ` Alan Modra
2006-10-25 7:39 ` Paolo Bonzini
2006-10-25 23:55 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061025235613.GM26170@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=paolo.bonzini@lu.unisi.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox