[rfc] target_read_memory_partial in gdbtk-cmds.c

[rfc] target_read_memory_partial in gdbtk-cmds.c

[Ronald Hecht]

As target_read_memory_partial was removed, gdbtk doesn't compile anymore:

gcc -c -g -I. -I. -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" 
-DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd 
-I./../bfd -I./../include -DMI_OUT=1 -DGDBTK -DTUI=1 -Wimplicit 
-Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses 
-Wpointer-arith -Wformat-nonliteral -Wunused-label -Wunused-function 
-Wno-pointer-sign -Werror -I./../libgui/src 
-I/home/ronald/sandbox/cgen/src/itcl/itcl/generic \
-I/home/ronald/sandbox/cgen/src/tcl/generic 
-I/home/ronald/sandbox/cgen/src/tk/generic -I/usr/X11R6/include \
./gdbtk/generic/gdbtk-cmds.c \
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\"
cc1: warnings being treated as errors
./gdbtk/generic/gdbtk-cmds.c: In function ‘gdb_update_mem’:
./gdbtk/generic/gdbtk-cmds.c:2436: warning: implicit declaration of 
function ‘target_read_memory_partial’
make: *** [gdbtk-cmds.o] Error 1

Just replacing the function with target_read_memory compiles, but seems 
not to work.

Regards
Ronald

Re: [rfc] target_read_memory_partial in gdbtk-cmds.c

[Daniel Jacobowitz]

CC'ing this to the insight list; it is maintained separately.

On Fri, Aug 18, 2006 at 11:25:29AM +0200, Ronald Hecht wrote:
> As target_read_memory_partial was removed, gdbtk doesn't compile anymore:
> 
> gcc -c -g -I. -I. -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" 
> -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd 
> -I./../bfd -I./../include -DMI_OUT=1 -DGDBTK -DTUI=1 -Wimplicit 
> -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses 
> -Wpointer-arith -Wformat-nonliteral -Wunused-label -Wunused-function 
> -Wno-pointer-sign -Werror -I./../libgui/src 
> -I/home/ronald/sandbox/cgen/src/itcl/itcl/generic \
> -I/home/ronald/sandbox/cgen/src/tcl/generic 
> -I/home/ronald/sandbox/cgen/src/tk/generic -I/usr/X11R6/include \
> ./gdbtk/generic/gdbtk-cmds.c \
> -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\"
> cc1: warnings being treated as errors
> ./gdbtk/generic/gdbtk-cmds.c: In function ?gdb_update_mem?:
> ./gdbtk/generic/gdbtk-cmds.c:2436: warning: implicit declaration of 
> function ?target_read_memory_partial?
> make: *** [gdbtk-cmds.o] Error 1
> 
> Just replacing the function with target_read_memory compiles, but seems 
> not to work.

I believe they have different return value conventions.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [rfc] target_read_memory_partial in gdbtk-cmds.c

[Daniel Jacobowitz]

On Fri, Aug 18, 2006 at 09:28:33AM -0400, Daniel Jacobowitz wrote:
> > Just replacing the function with target_read_memory compiles, but seems 
> > not to work.
> 
> I believe they have different return value conventions.

Oh, Vladimir discovered this separately last month.  At the time there
wasn't a viable replacement function but now there is; I believe
it should use target_read (TARGET_OBJECT_MEMORY).

-- 
Daniel Jacobowitz
CodeSourcery