From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23811 invoked by alias); 18 Aug 2006 13:28:40 -0000 Received: (qmail 23801 invoked by uid 22791); 18 Aug 2006 13:28:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 18 Aug 2006 13:28:38 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GE4On-0006U5-F9; Fri, 18 Aug 2006 09:28:33 -0400 Date: Sat, 19 Aug 2006 04:20:00 -0000 From: Daniel Jacobowitz To: Ronald Hecht , insight@sourceware.org Cc: gdb-patches@sources.redhat.com Subject: Re: [rfc] target_read_memory_partial in gdbtk-cmds.c Message-ID: <20060818132833.GB24799@nevyn.them.org> Mail-Followup-To: Ronald Hecht , insight@sourceware.org, gdb-patches@sources.redhat.com References: <44E58789.2030703@uni-rostock.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44E58789.2030703@uni-rostock.de> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00125.txt.bz2 CC'ing this to the insight list; it is maintained separately. On Fri, Aug 18, 2006 at 11:25:29AM +0200, Ronald Hecht wrote: > As target_read_memory_partial was removed, gdbtk doesn't compile anymore: > > gcc -c -g -I. -I. -I./config -DLOCALEDIR="\"/usr/local/share/locale\"" > -DHAVE_CONFIG_H -I./../include/opcode -I./../readline/.. -I../bfd > -I./../bfd -I./../include -DMI_OUT=1 -DGDBTK -DTUI=1 -Wimplicit > -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses > -Wpointer-arith -Wformat-nonliteral -Wunused-label -Wunused-function > -Wno-pointer-sign -Werror -I./../libgui/src > -I/home/ronald/sandbox/cgen/src/itcl/itcl/generic \ > -I/home/ronald/sandbox/cgen/src/tcl/generic > -I/home/ronald/sandbox/cgen/src/tk/generic -I/usr/X11R6/include \ > ./gdbtk/generic/gdbtk-cmds.c \ > -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" > cc1: warnings being treated as errors > ./gdbtk/generic/gdbtk-cmds.c: In function ?gdb_update_mem?: > ./gdbtk/generic/gdbtk-cmds.c:2436: warning: implicit declaration of > function ?target_read_memory_partial? > make: *** [gdbtk-cmds.o] Error 1 > > Just replacing the function with target_read_memory compiles, but seems > not to work. I believe they have different return value conventions. -- Daniel Jacobowitz CodeSourcery