Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA/testsuite] Adjust step-bt testcase
@ 2006-08-10 13:05 Joel Brobecker
  2006-08-10 15:21 ` Daniel Jacobowitz
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2006-08-10 13:05 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Hello Daniel,

  re: http://www.sourceware.org/ml/gdb/2006-08/msg00079.html

Would the attached patch fix your problem?

2006-08-09  Joel Brobecker  <brobecker@adacore.com>

        * gdb.base/step-bt.exp: Make hexadecimal address option in
        expected output of the backtrace commands.

Tested on x86-linux, no regression.

Thanks,
-- 
Joel

[-- Attachment #2: step-bt.diff --]
[-- Type: text/plain, Size: 889 bytes --]

Index: step-bt.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/step-bt.exp,v
retrieving revision 1.1
diff -u -p -r1.1 step-bt.exp
--- step-bt.exp	8 Aug 2006 21:50:54 -0000	1.1
+++ step-bt.exp	10 Aug 2006 04:10:02 -0000
@@ -63,7 +63,7 @@ gdb_test "stepi" \
          "step first instruction"
 
 gdb_test "bt" \
-         "#0 +0x\[0-9a-z\]+ in hello .*#1 +0x\[0-9a-z\]* in main.*" \
+         "#0 +(0x\[0-9a-z\]+)? in hello .*#1 +0x\[0-9a-z\]* in main.*" \
          "backtrace after first instruction step"
 
 gdb_test "stepi" \
@@ -71,6 +71,6 @@ gdb_test "stepi" \
          "step second instruction"
 
 gdb_test "bt" \
-         "#0 +0x\[0-9a-z\]+ in hello .*#1 +0x\[0-9a-z\]* in main.*" \
+         "#0 +(0x\[0-9a-z\]+)? in hello .*#1 +0x\[0-9a-z\]* in main.*" \
          "backtrace after second instruction step"
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA/testsuite] Adjust step-bt testcase
  2006-08-10 13:05 [RFA/testsuite] Adjust step-bt testcase Joel Brobecker
@ 2006-08-10 15:21 ` Daniel Jacobowitz
  2006-08-10 15:22   ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2006-08-10 15:21 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

On Wed, Aug 09, 2006 at 09:12:58PM -0700, Joel Brobecker wrote:
> Hello Daniel,
> 
>   re: http://www.sourceware.org/ml/gdb/2006-08/msg00079.html
> 
> Would the attached patch fix your problem?

Nope - the "in" is apparently optional too.  I tested and committed
this variant.

-- 
Daniel Jacobowitz
CodeSourcery

2006-08-10  Joel Brobecker  <brobecker@adacore.com>
	    Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.base/step-bt.exp: Make hexadecimal address optional in
	expected output of the backtrace commands.

Index: step-bt.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/step-bt.exp,v
retrieving revision 1.1
diff -u -p -r1.1 step-bt.exp
--- step-bt.exp	8 Aug 2006 21:50:54 -0000	1.1
+++ step-bt.exp	10 Aug 2006 13:03:19 -0000
@@ -63,7 +63,7 @@ gdb_test "stepi" \
          "step first instruction"
 
 gdb_test "bt" \
-         "#0 +0x\[0-9a-z\]+ in hello .*#1 +0x\[0-9a-z\]* in main.*" \
+         "#0 +(0x\[0-9a-z\]+ in )?hello .*#1 +(0x\[0-9a-z\]* in )?main.*" \
          "backtrace after first instruction step"
 
 gdb_test "stepi" \
@@ -71,6 +71,6 @@ gdb_test "stepi" \
          "step second instruction"
 
 gdb_test "bt" \
-         "#0 +0x\[0-9a-z\]+ in hello .*#1 +0x\[0-9a-z\]* in main.*" \
+         "#0 +(0x\[0-9a-z\]+ in )?hello .*#1 +(0x\[0-9a-z\]* in )?main.*" \
          "backtrace after second instruction step"
 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA/testsuite] Adjust step-bt testcase
  2006-08-10 15:21 ` Daniel Jacobowitz
@ 2006-08-10 15:22   ` Joel Brobecker
  0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2006-08-10 15:22 UTC (permalink / raw)
  To: gdb-patches

> Nope - the "in" is apparently optional too.  I tested and committed
> this variant.

Ah, yes, of course! Thanks for fixing it.

-- 
Joel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-08-10 14:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-10 13:05 [RFA/testsuite] Adjust step-bt testcase Joel Brobecker
2006-08-10 15:21 ` Daniel Jacobowitz
2006-08-10 15:22   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox