Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] set/unset/show substitute-path commands (take 2)
Date: Tue, 25 Jul 2006 16:38:00 -0000	[thread overview]
Message-ID: <20060725163822.GA15082@nevyn.them.org> (raw)
In-Reply-To: <20060725162829.GC12362@adacore.com>

On Tue, Jul 25, 2006 at 09:28:29AM -0700, Joel Brobecker wrote:
>         * source.c: #include gdb_assert.h.
>         (substitute_path_rule): New struct.
>         (substitute_path_rules): New static global variable.
>         (substitute_path_rule_matches): New function.
>         (get_substitute_path_rule): New function.
>         (rewrite_source_path): New function.
>         (find_and_open_source): Add source path rewriting support.
>         (strip_trailing_directory_separator): New function.
>         (find_substitute_path_rule): New function.
>         (add_substitute_path_rule): New function.
>         (delete_substitute_path_rule): New function.
>         (show_substitute_path_command): New function.
>         (unset_substitute_path_command): New function.
>         (set_substitute_path_command): New function.
>         (_initialize_source): Add new substitute-path commands.
>         * Makefile.in (source.o): Add dependency on gdb_assert.h.
> 
> Does it look better? Tested on x86-linux.

OK.  Let's go with this version.  It needs documentation, testcase, and
probably NEWS; those can be next :-)

Thanks!  Feel free to commit.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-07-25 16:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-15  5:49 Joel Brobecker
2006-07-17  9:19 ` Andrew STUBBS
2006-07-17  9:29 ` Andrew STUBBS
2006-07-17 17:09   ` Joel Brobecker
2006-07-17 17:32     ` Daniel Jacobowitz
2006-07-17 17:46     ` Andrew STUBBS
2006-07-19 18:15 ` Joel Brobecker
2006-07-24 20:25   ` Daniel Jacobowitz
2006-07-25 16:28     ` Joel Brobecker
2006-07-25 16:38       ` Daniel Jacobowitz [this message]
2006-08-08 22:19         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060725163822.GA15082@nevyn.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox