From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30204 invoked by alias); 25 Jul 2006 16:38:30 -0000 Received: (qmail 30196 invoked by uid 22791); 25 Jul 2006 16:38:29 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 25 Jul 2006 16:38:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G5PvK-0003vk-U9; Tue, 25 Jul 2006 12:38:23 -0400 Date: Tue, 25 Jul 2006 16:38:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] set/unset/show substitute-path commands (take 2) Message-ID: <20060725163822.GA15082@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20060715054902.GD1393@adacore.com> <20060719181516.GO15273@adacore.com> <20060724202545.GD15759@nevyn.them.org> <20060725162829.GC12362@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060725162829.GC12362@adacore.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00388.txt.bz2 On Tue, Jul 25, 2006 at 09:28:29AM -0700, Joel Brobecker wrote: > * source.c: #include gdb_assert.h. > (substitute_path_rule): New struct. > (substitute_path_rules): New static global variable. > (substitute_path_rule_matches): New function. > (get_substitute_path_rule): New function. > (rewrite_source_path): New function. > (find_and_open_source): Add source path rewriting support. > (strip_trailing_directory_separator): New function. > (find_substitute_path_rule): New function. > (add_substitute_path_rule): New function. > (delete_substitute_path_rule): New function. > (show_substitute_path_command): New function. > (unset_substitute_path_command): New function. > (set_substitute_path_command): New function. > (_initialize_source): Add new substitute-path commands. > * Makefile.in (source.o): Add dependency on gdb_assert.h. > > Does it look better? Tested on x86-linux. OK. Let's go with this version. It needs documentation, testcase, and probably NEWS; those can be next :-) Thanks! Feel free to commit. -- Daniel Jacobowitz CodeSourcery