From: Vladimir Prus <vladimir@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Flash support part 2: flash programming
Date: Fri, 21 Jul 2006 11:36:00 -0000 [thread overview]
Message-ID: <200607211536.35254.vladimir@codesourcery.com> (raw)
In-Reply-To: <u3bcwhxso.fsf@gnu.org>
On Thursday 20 July 2006 23:38, Eli Zaretskii wrote:
> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Thu, 20 Jul 2006 13:42:30 +0400
> >
> > +/* Calls the first non-null to_flash_done pointer in target_stack. */
> > +void target_flash_done ();
>
> Should this be a full prototype, including the parameters?
Yes, it should.
> > +target_write_memory_blocks (VEC(memory_write_request)
> > *memory_write_requests, + int
> > (*flash_write_allowed)(),
> > + enum flash_preserve_mode
> > (*preserve_flash)(),
>
> And the same for these two.
>
> > + error(_("Flash region erased by not written"));
>
> Did you maybe mean "... BUT not written"? If not, I cannot parse this
> message.
Exactly, I meant "but not written". Will fix.
- Volodya
next prev parent reply other threads:[~2006-07-21 11:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 9:42 Vladimir Prus
2006-07-20 19:38 ` Eli Zaretskii
2006-07-21 11:36 ` Vladimir Prus [this message]
2006-07-31 13:31 ` Vladimir Prus
2006-07-31 22:23 ` Mark Kettenis
2006-08-01 5:24 ` Vladimir Prus
2006-08-01 13:13 ` Daniel Jacobowitz
2006-08-01 13:20 ` Vladimir Prus
2006-08-01 13:23 ` Daniel Jacobowitz
2006-08-16 20:34 ` Daniel Jacobowitz
2006-08-16 20:32 ` Daniel Jacobowitz
2006-09-21 13:58 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607211536.35254.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox