Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	eliz@gnu.org, 	gdb-patches@sources.redhat.com
Subject: Re: Flash support part 2: flash programming
Date: Tue, 01 Aug 2006 13:13:00 -0000	[thread overview]
Message-ID: <20060801131252.GA9084@nevyn.them.org> (raw)
In-Reply-To: <200608010923.25082.vladimir@codesourcery.com>

On Tue, Aug 01, 2006 at 09:23:23AM +0400, Vladimir Prus wrote:
> No, this is intentional change. The target_write_memory_blocks uses it, and it 
> was made explicitly so that we can produce progress report while loading 
> data. It's currently used by MI frontend, and if target_write_memory_blocks 
> is coded to call progress reporting routine only at the end of a section, it 
> will make progress reporting much less usefull.

Vlad, I'm a little scared by how many versions of this patch are
floating around :-) I have a copy from the internal list on 2006-07-12
which uses target_write_memory instead.  And there's also the
xfer_partial_using_stratum change we discussed, in order to keep using
target_write_memory_partial.

But the last suggestion I can find in the discussion was:

> But that suggests there's a simpler way to do it.  We could break out
> target_write into another function, target_write_with_progress, that
> takes a progress callback.  Have target_write call that without a
> callback.  Then you could use the new interface to write out large
> chunks of data, without having to perform the partial transfers
> yourself, or having to do the bookkeeping for the progress bar.
> Maybe that would be easier.

I think that may be the way to go; I don't really want to re-export
target_write_partial if we can avoid it.  I realize you're not going to
have time to revise these for a while, so I may take care of this,
once we're finished with expat.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-08-01 13:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-20  9:42 Vladimir Prus
2006-07-20 19:38 ` Eli Zaretskii
2006-07-21 11:36   ` Vladimir Prus
2006-07-31 13:31   ` Vladimir Prus
2006-07-31 22:23     ` Mark Kettenis
2006-08-01  5:24       ` Vladimir Prus
2006-08-01 13:13         ` Daniel Jacobowitz [this message]
2006-08-01 13:20           ` Vladimir Prus
2006-08-01 13:23             ` Daniel Jacobowitz
2006-08-16 20:34               ` Daniel Jacobowitz
2006-08-16 20:32                 ` Daniel Jacobowitz
2006-09-21 13:58                 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060801131252.GA9084@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox