From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16894 invoked by alias); 21 Jul 2006 11:36:46 -0000 Received: (qmail 16877 invoked by uid 22791); 21 Jul 2006 11:36:44 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Jul 2006 11:36:42 +0000 Received: (qmail 363 invoked from network); 21 Jul 2006 11:36:40 -0000 Received: from unknown (HELO zigzag.lvk.cs.msu.su) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Jul 2006 11:36:40 -0000 From: Vladimir Prus To: Eli Zaretskii Subject: Re: Flash support part 2: flash programming Date: Fri, 21 Jul 2006 11:36:00 -0000 User-Agent: KMail/1.7.2 Cc: gdb-patches@sources.redhat.com References: <200607201342.30712.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200607211536.35254.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00289.txt.bz2 On Thursday 20 July 2006 23:38, Eli Zaretskii wrote: > > From: Vladimir Prus > > Date: Thu, 20 Jul 2006 13:42:30 +0400 > > > > +/* Calls the first non-null to_flash_done pointer in target_stack. */ > > +void target_flash_done (); > > Should this be a full prototype, including the parameters? Yes, it should. > > +target_write_memory_blocks (VEC(memory_write_request) > > *memory_write_requests, + int > > (*flash_write_allowed)(), > > + enum flash_preserve_mode > > (*preserve_flash)(), > > And the same for these two. > > > + error(_("Flash region erased by not written")); > > Did you maybe mean "... BUT not written"? If not, I cannot parse this > message. Exactly, I meant "but not written". Will fix. - Volodya