[RFA/RFC/testsuite] Adjust "help unset" test

[RFA/RFC/testsuite] Adjust "help unset" test

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Hello,

:ADDPATCH testsuite:

While working on adding the "substitute-path" set of commands,
I noticed that the addition made one test fail because the output
of "help unset" now contains a new entry in the list of available
unset commands.

I am not sure we are trying to verify the exact output of this
command, and hence the output for each and every available unset
command. It seems to me that it's good enough to verify the start
and end of the output which should not change after new unset
commands are added. It's a bit similar to what we do when we test
the "help set"...

So I simply modified the expected output to accept any list of
unset commands inside the help text. Of course, if others disagree,
I am happy to just add the help of my new command.

2006-07-07  Joel Brobecker  <brobecker@adacore.com>

        * gdb.base/help.exp: Adjust "help unset" test to accept
        any list of unset commands.

Tested on x86-linux. OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: help.exp.diff --]
[-- Type: text/plain, Size: 1359 bytes --]

Index: help.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/help.exp,v
retrieving revision 1.20
diff -u -p -r1.20 help.exp
--- help.exp	7 May 2006 20:50:35 -0000	1.20
+++ help.exp	7 Jul 2006 19:14:25 -0000
@@ -572,7 +572,7 @@ gdb_test "help undisplay" "Cancel some e
 # test help unset environment
 gdb_test "help unset environment" "Cancel environment variable VAR for the program\.\[\r\n\]+This does not affect the program until the next \"run\" command\." "help unset environment"
 # test help unset
-gdb_test "help unset" "Complement to certain \"set\" commands\.\[\r\n\]+List of unset subcommands:\[\r\n\]+unset environment -- Cancel environment variable VAR for the program\[\r\n\]+Type \"help unset\" followed by unset subcommand name for full documentation\.\[\r\n\]+Command name abbreviations are allowed if unambiguous\." "help unset"
+gdb_test "help unset" "Complement to certain \"set\" commands\.\[\r\n\]+List of unset subcommands:\[\r\n\]+.*Type \"help unset\" followed by unset subcommand name for full documentation\.\[\r\n\]+Command name abbreviations are allowed if unambiguous\." "help unset"
 # test help up
 gdb_test "help up" "Select and print stack frame that called this one\.\[\r\n\]+An argument says how many frames up to go\." "help up"
 # test help up-silently

Re: [RFA/RFC/testsuite] Adjust "help unset" test

[Daniel Jacobowitz]

On Fri, Jul 07, 2006 at 12:22:54PM -0700, Joel Brobecker wrote:
> So I simply modified the expected output to accept any list of
> unset commands inside the help text. Of course, if others disagree,
> I am happy to just add the help of my new command.
> 
> 2006-07-07  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdb.base/help.exp: Adjust "help unset" test to accept
>         any list of unset commands.
> 
> Tested on x86-linux. OK to apply?

Sensible.  This is OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA/RFC/testsuite] Adjust "help unset" test

[Joel Brobecker]

> > 2006-07-07  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * gdb.base/help.exp: Adjust "help unset" test to accept
> >         any list of unset commands.
> > 
> > Tested on x86-linux. OK to apply?
> 
> Sensible.  This is OK, thanks.

Thank you. Checked in.

-- 
Joel