From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28878 invoked by alias); 7 Jul 2006 19:22:59 -0000 Received: (qmail 28870 invoked by uid 22791); 7 Jul 2006 19:22:59 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Jul 2006 19:22:58 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 2938748CF2C for ; Fri, 7 Jul 2006 15:22:56 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 14802-01-6 for ; Fri, 7 Jul 2006 15:22:56 -0400 (EDT) Received: from takamaka.act-europe.fr (S0106000625ac85e1.vs.shawcable.net [70.71.27.110]) by nile.gnat.com (Postfix) with ESMTP id B0A6C48CC18 for ; Fri, 7 Jul 2006 15:22:55 -0400 (EDT) Received: by takamaka.act-europe.fr (Postfix, from userid 507) id D2DB147EFA; Fri, 7 Jul 2006 12:22:54 -0700 (PDT) Date: Fri, 07 Jul 2006 19:22:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA/RFC/testsuite] Adjust "help unset" test Message-ID: <20060707192254.GE971@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="gr/z0/N6AeWAPJVB" Content-Disposition: inline User-Agent: Mutt/1.4i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00063.txt.bz2 --gr/z0/N6AeWAPJVB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 972 Hello, :ADDPATCH testsuite: While working on adding the "substitute-path" set of commands, I noticed that the addition made one test fail because the output of "help unset" now contains a new entry in the list of available unset commands. I am not sure we are trying to verify the exact output of this command, and hence the output for each and every available unset command. It seems to me that it's good enough to verify the start and end of the output which should not change after new unset commands are added. It's a bit similar to what we do when we test the "help set"... So I simply modified the expected output to accept any list of unset commands inside the help text. Of course, if others disagree, I am happy to just add the help of my new command. 2006-07-07 Joel Brobecker * gdb.base/help.exp: Adjust "help unset" test to accept any list of unset commands. Tested on x86-linux. OK to apply? Thanks, -- Joel --gr/z0/N6AeWAPJVB Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="help.exp.diff" Content-length: 1359 Index: help.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/help.exp,v retrieving revision 1.20 diff -u -p -r1.20 help.exp --- help.exp 7 May 2006 20:50:35 -0000 1.20 +++ help.exp 7 Jul 2006 19:14:25 -0000 @@ -572,7 +572,7 @@ gdb_test "help undisplay" "Cancel some e # test help unset environment gdb_test "help unset environment" "Cancel environment variable VAR for the program\.\[\r\n\]+This does not affect the program until the next \"run\" command\." "help unset environment" # test help unset -gdb_test "help unset" "Complement to certain \"set\" commands\.\[\r\n\]+List of unset subcommands:\[\r\n\]+unset environment -- Cancel environment variable VAR for the program\[\r\n\]+Type \"help unset\" followed by unset subcommand name for full documentation\.\[\r\n\]+Command name abbreviations are allowed if unambiguous\." "help unset" +gdb_test "help unset" "Complement to certain \"set\" commands\.\[\r\n\]+List of unset subcommands:\[\r\n\]+.*Type \"help unset\" followed by unset subcommand name for full documentation\.\[\r\n\]+Command name abbreviations are allowed if unambiguous\." "help unset" # test help up gdb_test "help up" "Select and print stack frame that called this one\.\[\r\n\]+An argument says how many frames up to go\." "help up" # test help up-silently --gr/z0/N6AeWAPJVB--