From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] m32c-tdep.c: Add virtual_frame_pointer function
Date: Wed, 12 Jul 2006 19:13:00 -0000 [thread overview]
Message-ID: <20060712191332.GL24622@nevyn.them.org> (raw)
In-Reply-To: <20060629130844.GF18873@calimero.vinschen.de>
On Thu, Jun 29, 2006 at 03:08:44PM +0200, Corinna Vinschen wrote:
> On Jun 29 12:51, Corinna Vinschen wrote:
> > I see the point. I rewrote the m32c_virtual_frame_pointer function to
> > return a valid register/offset pair from the banked fb resp. sp
> > registers. Does that look ok?
>
> Oops! There was a copy/paste error in my patch, sorry about that.
> New patch below.
>
>
> Corinna
>
>
> * m32c-tdep.c (m32c_banked_register): New function.
> (m32c_banked_read): Use m32c_banked_register function to evaluate
> real register number.
> (m32c_banked_write): Ditto.
> (m32c_virtual_frame_pointer): New function.
> (m32c_gdbarch_init): Add set_gdbarch_virtual_frame_pointer call.
Yes, this looks fine to me. Thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-12 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 13:29 Corinna Vinschen
2006-06-28 21:29 ` Mark Kettenis
2006-06-28 21:34 ` DJ Delorie
2006-06-29 2:34 ` Daniel Jacobowitz
2006-06-29 10:51 ` Corinna Vinschen
2006-06-29 13:08 ` Corinna Vinschen
2006-07-12 19:13 ` Daniel Jacobowitz [this message]
2006-07-13 12:01 ` Corinna Vinschen
2006-06-29 13:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712191332.GL24622@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox