From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] m32c-tdep.c: Add virtual_frame_pointer function
Date: Wed, 28 Jun 2006 13:29:00 -0000 [thread overview]
Message-ID: <20060628132918.GD24606@calimero.vinschen.de> (raw)
Hi,
the below patch adds a virtual_frame_pointer function to m32c-tdep.c,
to avoid that legacy_virtual_frame_pointer is called from tracepoint.c,
function encode_actions(). The legacy function either expects a
DEPRECATED_FP_REGNUM function, or it expects SP_REGNUM <= NUM_REGS,
which is not the case for the m32c code which includes serious
register banking. The patch avoids all GDB internal errors in the
gdb.trace testsuite and allows to return PASSes for all these testcases,
except a single one (FAIL: gdb.trace/packetlen.exp: setup collect actions).
Ok to apply?
Thanks,
Corinna
* m32c-tdep.c (m32c_virtual_frame_pointer): New function.
(m32c_gdbarch_init): Add set_gdbarch_virtual_frame_pointer call.
Index: m32c-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m32c-tdep.c,v
retrieving revision 1.1
diff -u -p -r1.1 m32c-tdep.c
--- m32c-tdep.c 20 Apr 2006 23:18:48 -0000 1.1
+++ m32c-tdep.c 28 Jun 2006 13:20:38 -0000
@@ -2475,6 +2475,14 @@ m32c_m16c_pointer_to_address (struct typ
return ptr;
}
+void
+m32c_virtual_frame_pointer (CORE_ADDR pc,
+ int *frame_regnum,
+ LONGEST *frame_offset)
+{
+ *frame_regnum = SP_REGNUM;
+ *frame_offset = 0;
+}
\f
/* Initialization. */
@@ -2539,6 +2547,8 @@ m32c_gdbarch_init (struct gdbarch_info i
/* Trampolines. */
set_gdbarch_skip_trampoline_code (arch, m32c_skip_trampoline_code);
+ set_gdbarch_virtual_frame_pointer (arch, m32c_virtual_frame_pointer);
+
return arch;
}
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
next reply other threads:[~2006-06-28 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 13:29 Corinna Vinschen [this message]
2006-06-28 21:29 ` Mark Kettenis
2006-06-28 21:34 ` DJ Delorie
2006-06-29 2:34 ` Daniel Jacobowitz
2006-06-29 10:51 ` Corinna Vinschen
2006-06-29 13:08 ` Corinna Vinschen
2006-07-12 19:13 ` Daniel Jacobowitz
2006-07-13 12:01 ` Corinna Vinschen
2006-06-29 13:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628132918.GD24606@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox