From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6028 invoked by alias); 12 Jul 2006 19:13:36 -0000 Received: (qmail 6017 invoked by uid 22791); 12 Jul 2006 19:13:36 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 12 Jul 2006 19:13:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G0k9M-0007bM-RM for gdb-patches@sourceware.org; Wed, 12 Jul 2006 15:13:32 -0400 Date: Wed, 12 Jul 2006 19:13:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [PATCH] m32c-tdep.c: Add virtual_frame_pointer function Message-ID: <20060712191332.GL24622@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060628132918.GD24606@calimero.vinschen.de> <200606282129.k5SLTfc8004816@elgar.sibelius.xs4all.nl> <20060629023405.GA32465@nevyn.them.org> <20060629105116.GD18873@calimero.vinschen.de> <20060629130844.GF18873@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060629130844.GF18873@calimero.vinschen.de> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00124.txt.bz2 On Thu, Jun 29, 2006 at 03:08:44PM +0200, Corinna Vinschen wrote: > On Jun 29 12:51, Corinna Vinschen wrote: > > I see the point. I rewrote the m32c_virtual_frame_pointer function to > > return a valid register/offset pair from the banked fb resp. sp > > registers. Does that look ok? > > Oops! There was a copy/paste error in my patch, sorry about that. > New patch below. > > > Corinna > > > * m32c-tdep.c (m32c_banked_register): New function. > (m32c_banked_read): Use m32c_banked_register function to evaluate > real register number. > (m32c_banked_write): Ditto. > (m32c_virtual_frame_pointer): New function. > (m32c_gdbarch_init): Add set_gdbarch_virtual_frame_pointer call. Yes, this looks fine to me. Thanks. -- Daniel Jacobowitz CodeSourcery