Re: [patch] fix issues in some locales with using a-z

[Daniel Jacobowitz <drow@false.org>]

On Thu, Jun 22, 2006 at 12:05:42AM -0400, Mike Frysinger wrote:
> a bunch of files in gdb use a-z in sed expressions without forcing the locale 
> to c ... in some locales, this can cause some pretty "fun" results:
> 
> (observer.sh)
> In file included from solib.c:47:
> observer.h:35: error: stray '@' in program
> observer.h:35: error: expected ')' before 'deftypefun'
> 
> (Makefile.in:init.c)
> libgdb.a(init.o): In function `initialize_all_files':
> init.c:(.text+0xa): undefined reference to `_initialize_amd64_lin'
> init.c:(.text+0xf): undefined reference to `_initialize_i386_'
> 
> i've fixed this issue in the Makefile.in, gdb_indent.sh, gdb_mbuild,sh, and 
> observer.sh files the same way that gdbarch.sh was fixed oh-so-long ago 
> rather than the over-the-top way that autoconf does it (see the top of 
> gdb/configure under "NLS nuisances" to see what i mean)

Tsk tsk.  You must not have tested this patch too well; you made the
mistake I always make in multi-line Makefile commands:

> +	LANG=c ; export LANG ; \
> +	LC_ALL=c ; export LC_ALL ; \
>  	@-echo $(INIT_FILES) | \

@ and - are special only on the first command, not if you use
backslashes.

> +# Make certain that the script is running in an internationalized
> +# environment.

Don't you really mean "not" here?


-- 
Daniel Jacobowitz
CodeSourcery